[PATCH] tools: fix get_maintainers() returning None when no tree is found

Aaron Conole aconole at redhat.com
Fri Mar 6 14:34:42 CET 2026


Ali Alnubani <alialnu at nvidia.com> writes:

> get_maintainers() only returned when the tree was found in the
> "General Project Administration" section. If it was not found, the
> function fell through and returned None, causing:
>
>   TypeError: print() argument after * must be an iterable, not NoneType
>
> Return the maintainers list (even if empty) at the end of the
> function so callers always receive an iterable.
>
> Signed-off-by: Ali Alnubani <alialnu at nvidia.com>
> ---

Looks good to me - I just did some quick testing.

Thanks - applied.

>  tools/pw_maintainers_cli.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/pw_maintainers_cli.py b/tools/pw_maintainers_cli.py
> index d75ea96..b35f4bb 100755
> --- a/tools/pw_maintainers_cli.py
> +++ b/tools/pw_maintainers_cli.py
> @@ -198,6 +198,7 @@ class Maintainers(object):
>                              self.maintainer_regex, subsection)
>                      return maintainers
>                  break
> +        return maintainers
>  
>      def get_tree(self, files):
>          """



More information about the ci mailing list