<div dir="ltr"><div class="gmail_default" style="font-size:small">Hi Dmitry,</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">If the failing test is the unit test func_reentrancy_autotest, that is being looked into , as it seems like the test case does not reliably run. It passes / fails between different systems running both on bare metal and in virtual environments, on different OSes and architectures. </div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Do you have a link to your patch in patchworks or the lab dashboard?</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Cheers,<br>Lincoln</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small"> </div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jun 9, 2021 at 11:52 AM Dmitry Kozlyuk <<a href="mailto:dmitry.kozliuk@gmail.com">dmitry.kozliuk@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">2021-05-28 00:24 (UTC+0300), Dmitry Kozlyuk:<br>
> Size of string constant symbol may be larger than its length<br>
> measured up to NUL terminator. In this case pmdinfogen included padding<br>
> bytes after NUL terminator in generated source, yielding incorrect code.<br>
> <br>
> Always trim string data to NUL terminator while reading ELF.<br>
> It was already done for COFF because there's no symbol size.<br>
> <br>
> Bugzilla ID: 720<br>
> Fixes: f0f93a7adfee ("buildtools: use Python pmdinfogen")<br>
> <br>
> Signed-off-by: Dmitry Kozlyuk <<a href="mailto:dmitry.kozliuk@gmail.com" target="_blank">dmitry.kozliuk@gmail.com</a>><br>
> ---<br>
> v2: return helper to coff.py, where it's needed (David Marchand).<br>
> <br>
> buildtools/pmdinfogen.py | 2 +-<br>
> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
> <br>
> diff --git a/buildtools/pmdinfogen.py b/buildtools/pmdinfogen.py<br>
> index 7a739ec7d4..2a44f17bda 100755<br>
> --- a/buildtools/pmdinfogen.py<br>
> +++ b/buildtools/pmdinfogen.py<br>
> @@ -28,7 +28,7 @@ def __init__(self, image, symbol):<br>
> def string_value(self):<br>
> size = self._symbol["st_size"]<br>
> value = self.get_value(0, size)<br>
> - return value[:-1].decode() if value else ""<br>
> + return coff.decode_asciiz(value) # not COFF-specific<br>
> <br>
> def get_value(self, offset, size):<br>
> section = self._symbol["st_shndx"]<br>
<br>
There are CI failures that seem unrelated to this patch:<br>
some tests with NICs that I can't check<br>
and an Arch Linux build failure that I failed to reproduce.<br>
GitHub Actions are passing.<br>
Are these known CI bugs or does this patch need any corrections?<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div><b>Lincoln Lavoie</b><br></div><div>Principal Engineer, Broadband Technologies</div><div>21 Madbury Rd., Ste. 100, Durham, NH 03824</div><div><a href="mailto:lylavoie@iol.unh.edu" target="_blank">lylavoie@iol.unh.edu</a></div><div><a href="https://www.iol.unh.edu" target="_blank">https://www.iol.unh.edu</a></div><div>+1-603-674-2755 (m)</div><div><a href="https://www.iol.unh.edu" target="_blank"><img src="https://docs.google.com/uc?export=download&id=1j_iI6anwrnbQWNpTyuvukMLSNJJ8_8QU&revid=0B_0ujwABDnFZTmJiR3EzK0d1VjFKTjQvMENBWVM0QnA4ajhjPQ" width="200" height="43"></a><br></div></div></div></div></div></div></div></div></div></div></div>