<div dir="ltr"><div class="gmail_default" style="font-size:small">Ferruh and Thinh,</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Yes, that will also work and should trigger the rebuild to the tip of the current git repo / branch. Apologizes for forgetting that behavior is built into the runner.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">All,</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">That raises the question, for the planned work to allow triggering rebuilds / reruns through patchwork, what is the expected behavior, rerun exactly what was run before, or move to the current pointer (assuming it's moved on) and build/run on top of that? What best aligns with everyone's expectations, so we don't get confusion, etc.?</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Cheers,<br>Lincoln</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 11, 2021 at 8:58 PM Ferruh Yigit <<a href="mailto:ferruh.yigit@intel.com">ferruh.yigit@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 10/11/2021 11:45 PM, Thinh Tran wrote:<br> > Hi Brandon,<br> > <br> > Does the rebuild have the fix for RHEL 7? Please check.<br> > <br> > I just checked the build status, it still hits the same failure on RHEL 7:<br> <br> <a href="https://lab.dpdk.org/results/dashboard/patchsets/19066/" rel="noreferrer" target="_blank">https://lab.dpdk.org/results/dashboard/patchsets/19066/</a><br> <br> Your patch still applied on 'dpdk (086d426406bd3f6fac96a15bbd871c7fe714bc2d)',<br> which doesn't have the fix.<br> It seems 'Rebuild' still using the same commit from dpdk.<br> <br> Submitting a new version of the patch can be easiest solution to<br> run CI on correct version.<br> <br> > <br> > [1502/2903] Compiling C object drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o<br> > FAILED: drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o<br> > ccache cc -Idrivers/net/ice/base/libice_base.a.p -Idrivers/net/ice/base -I../drivers/net/ice/base -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O3 -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=native -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-unused-value -Wno-unused-but-set-variable -Wno-unused-variable -Wno-unused-parameter -MD -MQ <br> > drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o -MF drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o.d -o drivers/net/ice/base/libice_base.a.p/ice_parser_rt.c.o -c ../drivers/net/ice/base/ice_parser_rt.c<br> > ../drivers/net/ice/base/ice_parser_rt.c: In function '_hv_bit_sel':<br> > ../drivers/net/ice/base/ice_parser_rt.c:201:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]<br> > d64 = *(u64 *)&b[0];<br> > ^<br> > ../drivers/net/ice/base/ice_parser_rt.c: In function '_reg_bit_sel':<br> > ../drivers/net/ice/base/ice_parser_rt.c:458:2: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]<br> > d32 = *(u32 *)&v[0];<br> > ^<br> > cc1: all warnings being treated as errors<br> > <br> > Thanks,<br> > Thinh Tran<br> > <br> > On 10/11/2021 12:17 PM, Brandon Lo wrote:<br> >> Hi Thinh,<br> >><br> >> I have started a rerun of the patch<br> >> <a href="https://patches.dpdk.org/patch/100042" rel="noreferrer" target="_blank">https://patches.dpdk.org/patch/100042</a> (patchset<br> >> <a href="https://lab.dpdk.org/results/dashboard/patchsets/19066/" rel="noreferrer" target="_blank">https://lab.dpdk.org/results/dashboard/patchsets/19066/</a>).<br> >> You should see the new results reported over email soon.<br> >><br> >> Thanks,<br> >> Brandon<br> >><br> >><br> >> On Mon, Oct 11, 2021 at 12:39 PM Thinh Tran <<a href="mailto:thinhtr@linux.vnet.ibm.com" target="_blank">thinhtr@linux.vnet.ibm.com</a>> wrote:<br> >>><br> >>> Hi Linconln,<br> >>><br> >>> I have this patch set 100042 - build/ppc: enable build support for Power10<br> >>> <a href="https://patches.dpdk.org/patch/100042" rel="noreferrer" target="_blank">https://patches.dpdk.org/patch/100042</a><br> >>><br> >>> Thanks,<br> >>> Thinh Tran<br> >>><br> >>><br> >>><br> >>> On 10/11/2021 9:42 AM, Lincoln Lavoie wrote:<br> >>>> Hi Thinh, The CI won't automatically go back and retest failures after a<br> >>>> patch was applied. This is a corner case, where a bad change was merged<br> >>>> and affected all patches downstream of that merge. We can retrigger<br> >>>> specific patches, just ZjQcmQRYFpfptBannerStart<br> >>>> This Message Is From an External Sender<br> >>>> This message came from outside your organization.<br> >>>> ZjQcmQRYFpfptBannerEnd<br> >>>> Hi Thinh,<br> >>>><br> >>>> The CI won't automatically go back and retest failures after a patch was<br> >>>> applied. This is a corner case, where a bad change was merged and<br> >>>> affected all patches downstream of that merge. We can retrigger<br> >>>> specific patches, just let us know the patch number or the URI of the<br> >>>> patch(es).<br> >>>><br> >>>> Cheers,<br> >>>> Lincoln<br> >>>><br> >>>> On Mon, Oct 11, 2021 at 10:39 AM Thinh Tran <<a href="mailto:thinhtr@linux.vnet.ibm.com" target="_blank">thinhtr@linux.vnet.ibm.com</a><br> >>>> <mailto:<a href="mailto:thinhtr@linux.vnet.ibm.com" target="_blank">thinhtr@linux.vnet.ibm.com</a>>> wrote:<br> >>>><br> >>>><br> >>>> Hi,<br> >>>> I'm wondering how or when the CI would re-pick up the patches those<br> >>>> were<br> >>>> failed due to this issue?<br> >>>><br> >>>> Regards,<br> >>>> Thinh Tran<br> >>>><br> >>>> On 10/6/2021 10:40 PM, Zhang, Qi Z wrote:<br> >>>> > Hi Ferruh, David and Aman:<br> >>>> ><br> >>>> > Sorry for late response due to PRC holiday.<br> >>>> > I have just tested the patch and there is no issue be<br> >>>> detected for functions<br> >>>> > Thank you so much for the help!<br> >>>> ><br> >>>> > Regards<br> >>>> > Qi<br> >>>> ><br> >>>> >> -----Original Message-----<br> >>>> >> From: Yigit, Ferruh <<a href="mailto:ferruh.yigit@intel.com" target="_blank">ferruh.yigit@intel.com</a><br> >>>> <mailto:<a href="mailto:ferruh.yigit@intel.com" target="_blank">ferruh.yigit@intel.com</a>>><br> >>>> >> Sent: Wednesday, October 6, 2021 5:46 AM<br> >>>> >> To: Lincoln Lavoie <<a href="mailto:lylavoie@iol.unh.edu" target="_blank">lylavoie@iol.unh.edu</a><br> >>>> <mailto:<a href="mailto:lylavoie@iol.unh.edu" target="_blank">lylavoie@iol.unh.edu</a>>>; dev <<a href="mailto:dev@dpdk.org" target="_blank">dev@dpdk.org</a><br> >>>> <mailto:<a href="mailto:dev@dpdk.org" target="_blank">dev@dpdk.org</a>>>; Yang, Qiming<br> >>>> >> <<a href="mailto:qiming.yang@intel.com" target="_blank">qiming.yang@intel.com</a> <mailto:<a href="mailto:qiming.yang@intel.com" target="_blank">qiming.yang@intel.com</a>>>; Zhang,<br> >>>> Qi Z <<a href="mailto:qi.z.zhang@intel.com" target="_blank">qi.z.zhang@intel.com</a> <mailto:<a href="mailto:qi.z.zhang@intel.com" target="_blank">qi.z.zhang@intel.com</a>>><br> >>>> >> Cc: <a href="mailto:ci@dpdk.org" target="_blank">ci@dpdk.org</a> <mailto:<a href="mailto:ci@dpdk.org" target="_blank">ci@dpdk.org</a>>; Aaron Conole<br> >>>> <<a href="mailto:aconole@redhat.com" target="_blank">aconole@redhat.com</a> <mailto:<a href="mailto:aconole@redhat.com" target="_blank">aconole@redhat.com</a>>>; dpdklab<br> >>>> >> <<a href="mailto:dpdklab@iol.unh.edu" target="_blank">dpdklab@iol.unh.edu</a> <mailto:<a href="mailto:dpdklab@iol.unh.edu" target="_blank">dpdklab@iol.unh.edu</a>>>; Singh, Aman<br> >>>> Deep <<a href="mailto:aman.deep.singh@intel.com" target="_blank">aman.deep.singh@intel.com</a> <mailto:<a href="mailto:aman.deep.singh@intel.com" target="_blank">aman.deep.singh@intel.com</a>>>;<br> >>>> >> David Marchand <<a href="mailto:david.marchand@redhat.com" target="_blank">david.marchand@redhat.com</a><br> >>>> <mailto:<a href="mailto:david.marchand@redhat.com" target="_blank">david.marchand@redhat.com</a>>><br> >>>> >> Subject: Re: [dpdk-dev] RHEL7 failures<br> >>>> >><br> >>>> >> On 10/5/2021 8:09 PM, Lincoln Lavoie wrote:<br> >>>> >>> Hello Qiming and Qi,<br> >>>> >>><br> >>>> >>> The CI is picking up failures when building on RHEL7, where<br> >>>> warnings<br> >>>> >>> are being treated as errors. This looks like something has been<br> >>>> >>> merged into the mainline, as it's failing across all patches.<br> >>>> >>><br> >>>> >>> Here is the specific failure:<br> >>>> >>><br> >>>> >>> ./drivers/net/ice/base/ice_parser_rt.c: In function '_hv_bit_sel':<br> >>>> >>> ../drivers/net/ice/base/ice_parser_rt.c:201:2: error: dereferencing<br> >>>> >>> type-punned pointer will break strict-aliasing rules<br> >>>> >>> [-Werror=strict-aliasing]<br> >>>> >>> d64 = *(u64 *)&b[0];<br> >>>> >>> ^<br> >>>> >>> ../drivers/net/ice/base/ice_parser_rt.c: In function<br> >>>> '_reg_bit_sel':<br> >>>> >>> ../drivers/net/ice/base/ice_parser_rt.c:458:2: error: dereferencing<br> >>>> >>> type-punned pointer will break strict-aliasing rules<br> >>>> >>> [-Werror=strict-aliasing]<br> >>>> >>> d32 = *(u32 *)&v[0];<br> >>>> >>> ^<br> >>>> >>> cc1: all warnings being treated as errors<br> >>>> >>><br> >>>> >>> You can download a full set of logs from here (for a failing run):<br> >>>> >>> <a href="https://lab.dpdk.org/results/dashboard/patchsets/19162/" rel="noreferrer" target="_blank">https://lab.dpdk.org/results/dashboard/patchsets/19162/</a><br> >>>> <<a href="https://lab.dpdk.org/results/dashboard/patchsets/19162/" rel="noreferrer" target="_blank">https://lab.dpdk.org/results/dashboard/patchsets/19162/</a>><br> >>>> >>><br> >>>> >><br> >>>> >> Issue was reported by David, Aman sent the fix [1] and it is<br> >>>> already merged by<br> >>>> >> David [2], it should be fixed now, can you please double check?<br> >>>> >><br> >>>> >> [1]<br> >>>> >><br> >>>> <a href="https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman" rel="noreferrer" target="_blank">https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman</a><br> >>>> <<a href="https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman" rel="noreferrer" target="_blank">https://patches.dpdk.org/project/dpdk/patch/20211005115754.34117-1-aman</a>><br> >>>> >> .<a href="http://deep.singh@intel.com/" rel="noreferrer" target="_blank">deep.singh@intel.com/</a> <<a href="http://deep.singh@intel.com/" rel="noreferrer" target="_blank">http://deep.singh@intel.com/</a>><br> >>>> >><br> >>>> >> [2]<br> >>>> >><br> >>>> <a href="https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809" rel="noreferrer" target="_blank">https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809</a><br> >>>> <<a href="https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809" rel="noreferrer" target="_blank">https://git.dpdk.org/dpdk/commit/?id=16b809d144dc2df7f31695b5abc64a809</a>><br> >>>> >> 021b154<br> >>>><br> >>>><br> >>>><br> >>>> -- <br> >>>> *Lincoln Lavoie*<br> >>>> Principal Engineer, Broadband Technologies<br> >>>> 21 Madbury Rd., Ste. 100, Durham, NH 03824<br> >>>> <a href="mailto:lylavoie@iol.unh.edu" target="_blank">lylavoie@iol.unh.edu</a> <mailto:<a href="mailto:lylavoie@iol.unh.edu" target="_blank">lylavoie@iol.unh.edu</a>><br> >>>> <a href="https://www.iol.unh.edu" rel="noreferrer" target="_blank">https://www.iol.unh.edu</a> <<a href="https://www.iol.unh.edu" rel="noreferrer" target="_blank">https://www.iol.unh.edu</a>><br> >>>> +1-603-674-2755 (m)<br> >>>> <<a href="https://www.iol.unh.edu" rel="noreferrer" target="_blank">https://www.iol.unh.edu</a>><br> >><br> >><br> >><br> <br> </blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div><b>Lincoln Lavoie</b><br></div><div>Principal Engineer, Broadband Technologies</div><div>21 Madbury Rd., Ste. 100, Durham, NH 03824</div><div><a href="mailto:lylavoie@iol.unh.edu" target="_blank">lylavoie@iol.unh.edu</a></div><div><a href="https://www.iol.unh.edu" target="_blank">https://www.iol.unh.edu</a></div><div>+1-603-674-2755 (m)</div><div><a href="https://www.iol.unh.edu" target="_blank"><img src="https://docs.google.com/uc?export=download&id=1j_iI6anwrnbQWNpTyuvukMLSNJJ8_8QU&revid=0B_0ujwABDnFZTmJiR3EzK0d1VjFKTjQvMENBWVM0QnA4ajhjPQ" width="200" height="43"></a><br></div></div></div></div></div></div></div></div></div></div></div>