<div dir="ltr">Hi Ali,<div><br></div><div>Is this good to be merged since it's been acked by a maintainer with no more discussion afterwards? Or is there something more to be done here? </div><div><br></div><div>Thanks,</div><div>Patrick</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Apr 4, 2023 at 9:20 AM Ali Alnubani <<a href="mailto:alialnu@nvidia.com">alialnu@nvidia.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> -----Original Message-----<br>
> From: <a href="mailto:jspewock@iol.unh.edu" target="_blank">jspewock@iol.unh.edu</a> <<a href="mailto:jspewock@iol.unh.edu" target="_blank">jspewock@iol.unh.edu</a>><br>
> Sent: Monday, April 3, 2023 9:39 PM<br>
> To: <a href="mailto:ci@dpdk.org" target="_blank">ci@dpdk.org</a><br>
> Cc: Jeremy Spewock <<a href="mailto:jspewock@iol.unh.edu" target="_blank">jspewock@iol.unh.edu</a>><br>
> Subject: [PATCH v7 0/4] Add ACVP Tool<br>
> <br>
> From: Jeremy Spewock <<a href="mailto:jspewock@iol.unh.edu" target="_blank">jspewock@iol.unh.edu</a>><br>
> <br>
> v1: <a href="https://mails.dpdk.org/archives/ci/2022-January/001599.html" rel="noreferrer" target="_blank">https://mails.dpdk.org/archives/ci/2022-January/001599.html</a><br>
> v2: <a href="https://mails.dpdk.org/archives/ci/2022-January/001611.html" rel="noreferrer" target="_blank">https://mails.dpdk.org/archives/ci/2022-January/001611.html</a><br>
> v3: <a href="https://mails.dpdk.org/archives/ci/2022-February/001636.html" rel="noreferrer" target="_blank">https://mails.dpdk.org/archives/ci/2022-February/001636.html</a><br>
> v4: <a href="https://mails.dpdk.org/archives/ci/2022-April/001702.html" rel="noreferrer" target="_blank">https://mails.dpdk.org/archives/ci/2022-April/001702.html</a><br>
> v5: <a href="https://mails.dpdk.org/archives/ci/2023-March/002112.html" rel="noreferrer" target="_blank">https://mails.dpdk.org/archives/ci/2023-March/002112.html</a><br>
> v6: <a href="https://mails.dpdk.org/archives/ci/2023-March/002147.html" rel="noreferrer" target="_blank">https://mails.dpdk.org/archives/ci/2023-March/002147.html</a><br>
> v7:<br>
> * fix commit messages<br>
> * fix whitespace errors<br>
> <br>
> Brandon Lo (4):<br>
> tools: add acvp_tool<br>
> tools: add default config file for acvp_tool<br>
> tools: add requirements file for acvp_tool<br>
> doc: add readme file for acvp_tool<br>
> <br>
> tools/acvp/README | 118 +++++++++++++<br>
> tools/acvp/__init__.py | 0<br>
> tools/acvp/acvp_config.json | 52 ++++++<br>
> tools/acvp/acvp_tool.py | 319<br>
> ++++++++++++++++++++++++++++++++++++<br>
> tools/acvp/requirements.txt | 7 +<br>
> 5 files changed, 496 insertions(+)<br>
> create mode 100644 tools/acvp/README<br>
> create mode 100644 tools/acvp/__init__.py<br>
> create mode 100644 tools/acvp/acvp_config.json<br>
> create mode 100755 tools/acvp/acvp_tool.py<br>
> create mode 100644 tools/acvp/requirements.txt<br>
> <br>
> --<br>
> 2.40.0<br>
<br>
Thank you for addressing comments.<br>
<br>
Acked-by: Ali Alnubani <<a href="mailto:alialnu@nvidia.com" target="_blank">alialnu@nvidia.com</a>><br>
</blockquote></div><br clear="all"><div><br></div><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><p dir="ltr" style="line-height:1.2;margin-top:0pt;margin-bottom:0pt"><font color="#000000" face="Arial"><span style="font-size:13.3333px;white-space:pre-wrap">Patrick Robb</span></font></p><p style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline;white-space:pre-wrap">Technical Service Manager</span></p><p dir="ltr" style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline;white-space:pre-wrap">UNH InterOperability Laboratory</span></p><p dir="ltr" style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline;white-space:pre-wrap">21 Madbury Rd, Suite 100, Durham, NH 03824</span></p><p dir="ltr" style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10pt;font-family:Arial;color:rgb(17,85,204);background-color:transparent;vertical-align:baseline;white-space:pre-wrap"><a href="http://www.iol.unh.edu/" style="color:rgb(17,85,204)" target="_blank">www.iol.unh.edu</a></span></p><p dir="ltr" style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><br></p><p dir="ltr" style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10pt;font-family:Arial;color:rgb(51,51,51);background-color:transparent;vertical-align:baseline;white-space:pre-wrap"><img src="https://lh4.googleusercontent.com/7sTY8VswXadak_YT0J13osh5ockNVRX2BuYaRsKoTTpkpilBokA0WlocYHLB4q7XUgXNHka6-ns47S8R_am0sOt7MYQQ1ILQ3S-P5aezsrjp3-IsJMmMrErHWmTARNgZhpAx06n2" width="150" height="37" style="border: none;"></span></p></div></div>