<div dir="ltr"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Patrick, are [1/3] and [2/3] still needed as well?<br></blockquote><div>Yes please on both. We are currently using 1/3 in our Jenkins process for including tag arguments in creating the execution file. Thanks for raising this.</div><div><br></div><div> <br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jun 21, 2023 at 11:19 AM Ali Alnubani <<a href="mailto:alialnu@nvidia.com">alialnu@nvidia.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> -----Original Message-----<br>
> From: Ali Alnubani <<a href="mailto:alialnu@nvidia.com" target="_blank">alialnu@nvidia.com</a>><br>
> Sent: Monday, February 7, 2022 5:56 PM<br>
> To: <a href="mailto:ohilyard@iol.unh.edu" target="_blank">ohilyard@iol.unh.edu</a>; <a href="mailto:ci@dpdk.org" target="_blank">ci@dpdk.org</a><br>
> Subject: RE: [PATCH v5 3/3] pw_maintainers_cli: fix crash caused by empty diff<br>
> <br>
> > -----Original Message-----<br>
> > From: <a href="mailto:ohilyard@iol.unh.edu" target="_blank">ohilyard@iol.unh.edu</a> <<a href="mailto:ohilyard@iol.unh.edu" target="_blank">ohilyard@iol.unh.edu</a>><br>
> > Sent: Monday, February 7, 2022 5:08 PM<br>
> > To: <a href="mailto:ci@dpdk.org" target="_blank">ci@dpdk.org</a>; Ali Alnubani <<a href="mailto:alialnu@nvidia.com" target="_blank">alialnu@nvidia.com</a>><br>
> > Cc: Owen Hilyard <<a href="mailto:ohilyard@iol.unh.edu" target="_blank">ohilyard@iol.unh.edu</a>><br>
> > Subject: [PATCH v5 3/3] pw_maintainers_cli: fix crash caused by empty diff<br>
> ><br>
> > From: Owen Hilyard <<a href="mailto:ohilyard@iol.unh.edu" target="_blank">ohilyard@iol.unh.edu</a>><br>
> ><br>
> > A sanity check has been added to find_filenames. Occasionally, due to<br>
> > how the community lab internally handles getting patches from<br>
> > patchworks, a patch will result in no diff. This patch adds handling for<br>
> > this case.<br>
> ><br>
> > Signed-off-by: Owen Hilyard <<a href="mailto:ohilyard@iol.unh.edu" target="_blank">ohilyard@iol.unh.edu</a>><br>
> > ---<br>
> <br>
> Thanks Owen.<br>
> <br>
> Tested-by: Ali Alnubani <<a href="mailto:alialnu@nvidia.com" target="_blank">alialnu@nvidia.com</a>><br>
> Acked-by: Ali Alnubani <<a href="mailto:alialnu@nvidia.com" target="_blank">alialnu@nvidia.com</a>><br>
<br>
Hi Thomas and Aaron,<br>
<br>
Can we merge this patch? Pull requests can still cause the script to crash because they have an empty diff.<br>
<br>
Patrick, are [1/3] and [2/3] still needed as well?<br>
<br>
Thanks,<br>
Ali<br>
</blockquote></div><br clear="all"><div><br></div><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><p dir="ltr" style="line-height:1.2;margin-top:0pt;margin-bottom:0pt"><font color="#000000" face="Arial"><span style="font-size:13.3333px;white-space:pre-wrap">Patrick Robb</span></font></p><p style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline;white-space:pre-wrap">Technical Service Manager</span></p><p dir="ltr" style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline;white-space:pre-wrap">UNH InterOperability Laboratory</span></p><p dir="ltr" style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10pt;font-family:Arial;color:rgb(0,0,0);background-color:transparent;vertical-align:baseline;white-space:pre-wrap">21 Madbury Rd, Suite 100, Durham, NH 03824</span></p><p dir="ltr" style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10pt;font-family:Arial;color:rgb(17,85,204);background-color:transparent;vertical-align:baseline;white-space:pre-wrap"><a href="http://www.iol.unh.edu/" style="color:rgb(17,85,204)" target="_blank">www.iol.unh.edu</a></span></p><p dir="ltr" style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><br></p><p dir="ltr" style="color:rgb(34,34,34);line-height:1.2;margin-top:0pt;margin-bottom:0pt"><span style="font-size:10pt;font-family:Arial;color:rgb(51,51,51);background-color:transparent;vertical-align:baseline;white-space:pre-wrap"><img src="https://lh4.googleusercontent.com/7sTY8VswXadak_YT0J13osh5ockNVRX2BuYaRsKoTTpkpilBokA0WlocYHLB4q7XUgXNHka6-ns47S8R_am0sOt7MYQQ1ILQ3S-P5aezsrjp3-IsJMmMrErHWmTARNgZhpAx06n2" width="150" height="37" style="border: none;"></span></p></div></div>