<div dir="ltr">These issues are fixed in v8.<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jul 17, 2023 at 3:07 PM Aaron Conole <<a href="mailto:aconole@redhat.com">aconole@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Adam Hassick <<a href="mailto:ahassick@iol.unh.edu" target="_blank">ahassick@iol.unh.edu</a>> writes:<br>
<br>
> This patch series contains a new version of the DPDK CI containers. The old<br>
> version was tied very tightly to the Community Lab Infrastructure, so it was<br>
> not suitable for general use. This version is designed to make adding new<br>
> OSes or OS versions as easy as possible. The minimum functionality can easily<br>
> be built on any system that can compile DPDK. It includes support for<br>
> building containers for other non-native architectures (ex: arm containers<br>
> on x86) and for baking ABI references into the images.<br>
><br>
> The inventory file as added in this patch series defines what the community lab<br>
> currently supports.<br>
><br>
> If you want to build these yourself, don't try to do parallel Makefile builds<br>
> on non-server hardware. Libabigail is built into the containers, and since it<br>
> is not avaliable in all distros it is compiled from source for many targets.<br>
> If embedding the abi is enabled (DPDK_CI_CONTAINERS_BUILD_ABI=Y), with the<br>
> current settings, DPDK will be compiled twice for every target in the<br>
> inventory file. This will become three times when DPDK main has ABI stability<br>
> again. Due to how the containers are constructed, building on non-native<br>
> architectures is especially expensive because DPDK is compiled with an emulated<br>
> compiler in a qemu vm that only has one thread.<br>
><br>
> ---<br>
><br>
> v2:<br>
> * Added poetry.lock<br>
> * Remove duplicates in inventory file<br>
> * Fix typo in base container template<br>
><br>
> v3:<br>
> * Libabigail is now not built by default unless DPDK_CI_CONTAINERS_BUILD_ABI=y<br>
> * Made minimum podman version 4.0.0 due to dependencies on cache mounts<br>
><br>
> v4:<br>
> * Fix whitespace errors<br>
><br>
> v5:<br>
> * Updated container templates and inventory<br>
> * Add support for OCI manifests<br>
> * Update README to reflect changes<br>
><br>
> v6:<br>
> * Fix spelling errors and whitespace errors<br>
><br>
> v7:<br>
> * Add workaround to Arch template to install Python packages as root<br>
> * Compare against v4 and polish the patchset<br>
<br>
Please can you repost with the spelling fixes, and also fixing Owen's<br>
email address? (it is currently listed like a mailing list archive).<br>
<br>
> Owen Hilyard (6):<br>
> * Add README file for containers * Add pyproject file with required<br>
> dependencies for building containers<br>
> Adds a yaml file used to define what containers should be built, what<br>
> packages the containers should have, what platforms to build for and<br>
> how they should be tagged.<br>
> This script will template out all of the Dockerfiles based on the<br>
> definitions provided in the inventory using the jinja2 templating<br>
> library.<br>
> Adds a variety of extensible templates used to create the Dockerfiles<br>
> for each target. All templates inherit from base, and most distros<br>
> and distro families have their own templates that are used to define<br>
> common functionality. Multiple versions of a distro may use a single<br>
> template if they are similar enough (ex: fedora).<br>
> Adds a container that can be used to run the python scripts to create<br>
> the Dockerfiles for the CI containers. This removes a large number<br>
> of python environment dependencies from the host requirements.<br>
> The Makefile that can be used to build all of the container images<br>
> using "make build", and can also be used to push them to a remote<br>
> repository (for use in CI).<br>
><br>
> containers/Makefile | 252 ++++++++++<br>
> containers/README.md | 178 +++++++<br>
> containers/container_builder.dockerfile | 26 +<br>
> containers/template_engine/inventory.yaml | 470 ++++++++++++++++++<br>
> .../template_engine/inventory_schema.json | 221 ++++++++<br>
> containers/template_engine/make_dockerfile.py | 358 +++++++++++++<br>
> containers/template_engine/poetry.lock | 220 ++++++++<br>
> containers/template_engine/pyproject.toml | 21 +<br>
> .../templates/containers.makefile.j2 | 73 +++<br>
> .../templates/containers/alpine.dockerfile.j2 | 3 +<br>
> .../templates/containers/arch.dockerfile.j2 | 39 ++<br>
> .../templates/containers/base.dockerfile.j2 | 120 +++++<br>
> .../containers/centos8.dockerfile.j2 | 21 +<br>
> .../containers/centos9.dockerfile.j2 | 17 +<br>
> .../templates/containers/debian.dockerfile.j2 | 7 +<br>
> .../containers/debian10.dockerfile.j2 | 3 +<br>
> .../containers/debian11.dockerfile.j2 | 3 +<br>
> .../debian11_arm_ipsec.dockerfile.j2 | 16 +<br>
> .../containers/debian_bullseye.dockerfile.j2 | 3 +<br>
> .../containers/debian_buster.dockerfile.j2 | 3 +<br>
> .../templates/containers/fedora.dockerfile.j2 | 11 +<br>
> .../containers/fedora36_clang.dockerfile.j2 | 7 +<br>
> .../containers/fedora_clang.dockerfile.j2 | 8 +<br>
> .../containers/fedora_coverity.dockerfile.j2 | 10 +<br>
> .../containers/opensuse.dockerfile.j2 | 10 +<br>
> .../containers/redhat_family.dockerfile.j2 | 5 +<br>
> .../templates/containers/rhel.dockerfile.j2 | 16 +<br>
> .../templates/containers/rhel7.dockerfile.j2 | 15 +<br>
> .../templates/containers/rhel8.dockerfile.j2 | 15 +<br>
> .../templates/containers/rhel9.dockerfile.j2 | 19 +<br>
> .../templates/containers/rpm.dockerfile.j2 | 3 +<br>
> .../templates/containers/ubuntu.dockerfile.j2 | 3 +<br>
> .../containers/ubuntu20.04.dockerfile.j2 | 12 +<br>
> .../containers/ubuntu22.04.dockerfile.j2 | 3 +<br>
> .../containers/ubuntu_cross.dockerfile.j2 | 11 +<br>
> .../containers/ubuntu_sve.dockerfile.j2 | 12 +<br>
> 36 files changed, 2214 insertions(+)<br>
> create mode 100644 containers/Makefile<br>
> create mode 100644 containers/README.md<br>
> create mode 100644 containers/container_builder.dockerfile<br>
> create mode 100644 containers/template_engine/inventory.yaml<br>
> create mode 100644 containers/template_engine/inventory_schema.json<br>
> create mode 100755 containers/template_engine/make_dockerfile.py<br>
> create mode 100644 containers/template_engine/poetry.lock<br>
> create mode 100644 containers/template_engine/pyproject.toml<br>
> create mode 100644 containers/template_engine/templates/containers.makefile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/alpine.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/arch.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/base.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/centos8.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/centos9.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/debian.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/debian10.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/debian11.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/debian11_arm_ipsec.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/debian_bullseye.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/debian_buster.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/fedora.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/fedora36_clang.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/fedora_clang.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/fedora_coverity.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/opensuse.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/redhat_family.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/rhel.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/rhel7.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/rhel8.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/rhel9.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/rpm.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/ubuntu.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/ubuntu20.04.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/ubuntu22.04.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/ubuntu_cross.dockerfile.j2<br>
> create mode 100644 containers/template_engine/templates/containers/ubuntu_sve.dockerfile.j2<br>
<br>
</blockquote></div><br clear="all"><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><div><b><span style="background-color:rgb(255,255,255)"><span style="color:rgb(102,102,102)">Adam Hassick</span></span></b><br></div><span style="color:rgb(102,102,102)"></span></div><div><span style="color:rgb(102,102,102)">Senior Developer</span></div><div><span style="color:rgb(102,102,102)"><span style="color:rgb(11,83,148)"><span style="background-color:rgb(255,255,255)">UNH InterOperability Lab</span></span></span><span style="color:rgb(102,102,102)"></span></div><div><span style="color:rgb(102,102,102)"><a href="mailto:ahassick@iol.unh.edu" target="_blank">ahassick@iol.unh.edu</a><br></span></div><div><span style="color:rgb(102,102,102)"><a href="https://www.iol.unh.edu/" target="_blank">iol.unh.edu</a><br></span></div>+1 (603) 475-8248<br></div></div>