<div dir="ltr">Got it! I've re-enabled Werror now that the patch has been merged.<div> </div><div>Thanks, Cody</div></div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, May 28, 2024 at 5:41 PM Thomas Monjalon <<a href="mailto:thomas@monjalon.net" target="_blank">thomas@monjalon.net</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello, There was a patch pending for this issue. It has been merged quickly because it looks urgent, but I would have preferred a test of the patch from you. Next time ;) Thanks 28/05/2024 20:28, Cody Cheng: > Here is the warning: > > FAILED: lib/76b5a35@@rte_pcapng@sta/pcapng_rte_pcapng.c.o > ccache cc -Ilib/76b5a35@@rte_pcapng@sta -Ilib -I../lib -Ilib/pcapng > -I../lib/pcapng -I. -I../ -Iconfig -I../config -Ilib/eal/include > -I../lib/eal/include -Ilib/eal/linux/include > -I../lib/eal/linux/include -Ilib/eal/x86/include > -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common > -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log > -I../lib/log -Ilib/telemetry/../metrics -I../lib/telemetry/../metrics > -Ilib/telemetry -I../lib/telemetry -Ilib/ethdev -I../lib/ethdev > -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool > -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter > -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall > -Winvalid-pch -Wextra -Werror -std=c11 -O3 -include rte_config.h > -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral > -Wformat-security -Wmissing-declarations -Wmissing-prototypes > -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare > -Wstrict-prototypes -Wundef -Wwrite-strings > -Wno-address-of-packed-member -Wno-packed-not-aligned > -Wno-missing-field-initializers -Wno-zero-length-bounds -D_GNU_SOURCE > -fPIC -march=native -mrtm -DALLOW_EXPERIMENTAL_API > -DALLOW_INTERNAL_API -Wno-format-truncation > -DRTE_LOG_DEFAULT_LOGTYPE=lib.pcapng -MD -MQ > 'lib/76b5a35@@rte_pcapng@sta/pcapng_rte_pcapng.c.o' -MF > 'lib/76b5a35@@rte_pcapng@sta/pcapng_rte_pcapng.c.o.d' -o > 'lib/76b5a35@@rte_pcapng@sta/pcapng_rte_pcapng.c.o' -c > ../lib/pcapng/rte_pcapng.c > In file included from /usr/include/string.h:548, > from ../lib/pcapng/rte_pcapng.c:9: > In function ‘memcpy’, > inlined from ‘pcapng_add_option’ at ../lib/pcapng/rte_pcapng.c:131:2, > inlined from ‘pcapng_section_block’ at ../lib/pcapng/rte_pcapng.c:192:8: > /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: error: > argument 2 null where non-null expected [-Werror=nonnull] > 29 | return __builtin___memcpy_chk (__dest, __src, __len, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 30 | __glibc_objsize0 (__dest)); > | ~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: note: in > a call to built-in function ‘__builtin___memcpy_chk’ > In function ‘memcpy’, > inlined from ‘pcapng_add_option’ at ../lib/pcapng/rte_pcapng.c:131:2, > inlined from ‘rte_pcapng_add_interface’ at ../lib/pcapng/rte_pcapng.c:308:8: > /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: error: > argument 2 null where non-null expected [-Werror=nonnull] > 29 | return __builtin___memcpy_chk (__dest, __src, __len, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 30 | __glibc_objsize0 (__dest)); > | ~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: note: in > a call to built-in function ‘__builtin___memcpy_chk’ > In function ‘memcpy’, > inlined from ‘pcapng_add_option’ at ../lib/pcapng/rte_pcapng.c:131:2, > inlined from ‘rte_pcapng_write_stats’ at ../lib/pcapng/rte_pcapng.c:371:9: > /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: error: > argument 2 null where non-null expected [-Werror=nonnull] > 29 | return __builtin___memcpy_chk (__dest, __src, __len, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 30 | __glibc_objsize0 (__dest)); > | ~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/include/x86_64-linux-gnu/bits/string_fortified.h:29:10: note: in > a call to built-in function ‘__builtin___memcpy_chk’ > cc1: all warnings being treated as errors > > > On Tue, May 28, 2024 at 12:32 PM Cody Cheng <<a href="mailto:ccheng@iol.unh.edu" target="_blank">ccheng@iol.unh.edu</a>> wrote: > > > Hi, > > > > We have added the Ubuntu 24.04 environment to the Community Lab! Due to a > > warning in rte_pcapng.c, we have temporarily disabled Werror. Once this > > warning has been fixed, we will re-enable Werror. I have attached the logs > > for the warning error below. > > > > log.txt > > <<a href="https://drive.google.com/file/d/1qnBcQWg9AHG8RksjGjv8QaqTqw6yC3Gc/view?usp=drive_web" rel="noreferrer" target="_blank">https://drive.google.com/file/d/1qnBcQWg9AHG8RksjGjv8QaqTqw6yC3Gc/view?usp=drive_web</a>> > > > > Thanks, > > Cody > > > </blockquote></div>