<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi Patrick Robb,</p>
<p>Thanks for you efforts on retest framework! The get_reruns.py
script is really helpful. We will support the rebase argument this
week.<br>
</p>
<div class="moz-cite-prefix">On 2025/6/12 5:05AM, Patrick Robb
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAJvnSUB79G2-p3yjdqbtFzHrmFCQ87QkizHDJr1JbxCJro8u8g@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">Hi Min Zhou,
<div><br>
</div>
<div>Thanks for the response and for getting some retest
support online! I agree the next reasonable steps are to
continue to align out processes, in part so that the lab
behavior is predictable according to what is documented
on <a target="_blank"
href="https://mailgw.loongson.cn/linkserver?dest=http%3A%2F%2Fdpdk.org&tid=_____8AxfeHf8EloUBoUAQ--.8230S3&rcpt=zhoumin@loongson.cn&ifnotice=1&rindex=0"
moz-do-not-send="true">dpdk.org</a>. </div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Sat, Jun 7, 2025 at
8:50 PM zhoumin <<a href="mailto:zhoumin@loongson.cn"
target="_blank" moz-do-not-send="true">zhoumin@loongson.cn</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div>
<p>Yes, we don't support the rebase argument.
Meanwhile, for the sake of simplicity, the
rechecking behavior at Loongson lab is a little
different from the default behavior. we recheck the
patches on the latest HEAD of the branch selected by
pw_maintainers_cli.py script. This behavior is same
to that of the first testing for the commit at
Loongson lab. It's ok to be consistent with the
defualt behavior. Maybe we can support both it and
rebase argument after you have synced some
infrastructures.</p>
</div>
</blockquote>
<div>Good point, we need to make sure the support for the
rebase={branch} argument is integrated into the
get_reruns.py script in dpdk-ci. The UNH team made that
addition and it is available for patch review: <a
href="https://patchwork.dpdk.org/project/ci/patch/20250611205849.72165-1-probb@iol.unh.edu/"
moz-do-not-send="true">https://patchwork.dpdk.org/project/ci/patch/20250611205849.72165-1-probb@iol.unh.edu/</a></div>
<div><br>
</div>
<div>Maybe you can apply it, give it a run and add a
tested by tag to the patch if it is working for you?</div>
</div>
</div>
</div>
</div>
</blockquote>
Yes, I have tested it and it is working for me. This patch has a
little changes in the inputs and outputs to get_reruns.py, and I
need to make corresponding changes to our current implementation of
retest.<br>
<blockquote type="cite"
cite="mid:CAJvnSUB79G2-p3yjdqbtFzHrmFCQ87QkizHDJr1JbxCJro8u8g@mail.gmail.com">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div class="gmail_quote">
<div> In order to make sure it was working I submitted a
placeholder loongson recheck request with the rebase
argument (requesting the main branch) included on the
DPDK mailing list. Right now if I run the script with
the following args it produces this json:</div>
<div><br>
</div>
<div>python3 tools/get_reruns.py -ts 2025-06-10 --contexts
loongarch-compilation</div>
<div><br>
</div>
<div>output json: </div>
<div><br>
</div>
<div>{<br>
"retests": {<br>
"34851": {<br>
"contexts": [<br>
"loongarch-compilation"<br>
],<br>
"arguments": {<br>
"rebase": "main"<br>
}<br>
}<br>
},<br>
"last_comment_timestamp":
"2025-06-11T20:29:39.327426"<br>
}</div>
</div>
</div>
</div>
</div>
</blockquote>
</body>
</html>