<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p>Hi Patrick Robb,</p>
    <div class="moz-cite-prefix">On 2025/7/25 10:24PM, Patrick Robb
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAJvnSUDKFVyj+eQ6_LsFsSQ6SoZ73ZvfsYeCwcQv-CKW4Q9tzg@mail.gmail.com">
      <meta http-equiv="content-type" content="text/html; charset=UTF-8">
      <div dir="ltr">
        <div dir="ltr"><br>
        </div>
        <br>
        <div class="gmail_quote gmail_quote_container">
          <div dir="ltr" class="gmail_attr">On Thu, Jul 17, 2025 at
            8:50 AM zhoumin <<a href="mailto:zhoumin@loongson.cn"
              moz-do-not-send="true">zhoumin@loongson.cn</a>> wrote:<br>
          </div>
          <blockquote class="gmail_quote" style="margin:0px 0px 0px
            0.8ex;border-left:1px solid
            rgb(204,204,204);padding-left:1ex">
            <div>
              <p>Hi Patrick Robb,<br>
              </p>
              <div>On 2025/7/9 8:49AM, Patrick Robb wrote:<br>
              </div>
              <blockquote type="cite">
                <div dir="ltr">
                  <div dir="ltr">Hi Zhoumin,
                    <div><br>
                    </div>
                    <div>Aaron did approve the get_reruns.py patch for
                      the rebase arg and merge it to dpdk-ci. So, you
                      are good to pull that into your dpdk-ci fork.</div>
                  </div>
                  <br>
                </div>
              </blockquote>
              Thanks for your contributions. I have used this script to
              support the retest with rebase arg in Loongson lab.<br>
              <blockquote type="cite">
                <div dir="ltr">
                  <div class="gmail_quote">
                    <div dir="ltr" class="gmail_attr">On Tue, Jun 17,
                      2025 at 12:16 AM zhoumin <<a
                        href="mailto:zhoumin@loongson.cn"
                        target="_blank" moz-do-not-send="true">zhoumin@loongson.cn</a>>
                      wrote:<br>
                    </div>
                    <blockquote class="gmail_quote" style="margin:0px
                      0px 0px 0.8ex;border-left:1px solid
                      rgb(204,204,204);padding-left:1ex">
                      <div>
                        <blockquote type="cite">
                          <div dir="ltr">
                            <div dir="ltr">
                              <div dir="ltr">
                                <div class="gmail_quote">
                                  <div>Maybe you can apply it, give it a
                                    run and add a tested by tag to the
                                    patch if it is working for you?</div>
                                </div>
                              </div>
                            </div>
                          </div>
                        </blockquote>
                        Yes, I have tested it and it is working for me.
                        This patch has a little changes in the inputs
                        and outputs to get_reruns.py, and I need to make
                        corresponding changes to our current
                        implementation of retest.<br>
                        <blockquote type="cite">
                          <div dir="ltr">
                            <div dir="ltr">
                              <div dir="ltr">
                                <div class="gmail_quote">
                                  <div><br>
                                  </div>
                                </div>
                              </div>
                            </div>
                          </div>
                        </blockquote>
                      </div>
                    </blockquote>
                    <div>Okay, thanks. When you get the free time to
                      implement these change please ping me so I know we
                      are ready for any next steps (like updating the
                      labs recheck support status on the DPDK website).
                      <br>
                    </div>
                  </div>
                </div>
              </blockquote>
              We support the rebase arg now when request to retest. But
              there maybe a little difference between Loongson lab and
              other labs. We recheck the patches on the latest HEAD of
              the branch specified by rebase arg if has or selected by
              pw_maintainers_cli.py script. I want to know if there will
              be any problems with this behaviour? Is it acceptable?<br>
            </div>
          </blockquote>
          <div><br>
          </div>
          <div>The behavior you describe is correct - when the rebase
            argument is used, the patch should be applied to HEAD of the
            branch specified by the rebase arg.</div>
          <div><br>
          </div>
          <div>However, I do believe there is a discrepancy in our labs
            behavior when it comes to retests which are submitted
            without the rebase argument. In this case, UNH lab, AWS, and
            GitHub are running retests on the original patch artifacts
            without re-applying to the current HEAD at the time of the
            retest. On the other hand, I believe Loongson does re-apply
            to HEAD even when the rebase argument is not specified. I
            think in an ideal world our behavior would be uniform across
            the labs. What that would require in this case is either:</div>
          <div><br>
          </div>
          <div>1. Loongson changes to retesting without re-apply on HEAD
            when no rebase argument is given (unclear how much work this
            is)</div>
        </div>
      </div>
    </blockquote>
    I'm glad to say Loongson lab has changed to retesting without
    re-apply on HEAD when no rebase argument is given. We recorded the
    commit ID of the base for the series to test during the first test
    and use it as the base to retest if no rebase argument is specified.
    We also ensure that the patch will be applied to HEAD of the branch
    specified by the rebase argument if it exists.<br>
    <blockquote type="cite"
cite="mid:CAJvnSUDKFVyj+eQ6_LsFsSQ6SoZ73ZvfsYeCwcQv-CKW4Q9tzg@mail.gmail.com">
      <div dir="ltr">
        <div class="gmail_quote gmail_quote_container">
          <div>OR</div>
          <div>2. The other labs change their behavior to just re-apply
            on HEAD for every retest, regardless of the rebase argument
            situation (probably not a lot of implementation effort, but
            does reduce user flexibility a little).</div>
          <div><br>
          </div>
          <div>Sounds like a good topic to discuss at an upcoming CI
            meeting. :)</div>
          <div><br>
          </div>
          <div>I will send the dpdk-web patch noting that you have added
            rebase coverage. Thanks Min Zhou.</div>
          <div> </div>
          <blockquote class="gmail_quote" style="margin:0px 0px 0px
            0.8ex;border-left:1px solid
            rgb(204,204,204);padding-left:1ex">
            <div>  <br>
            </div>
          </blockquote>
        </div>
      </div>
    </blockquote>
  </body>
</html>