[dpdk-dev] [PATCH] app: fix refcnt in mbuf allocation

Han, Dongsu dongsu.han at gmail.com
Mon May 6 17:47:23 CEST 2013


In addition to this, we should probably clone pkt mbuf using
rte_pktmbuf_clone()
and transmit the cloned packet. This will avoid having to copy the mac and
IP headers.

-Dongsu

On Mon, May 6, 2013 at 9:56 AM, Adrien Mazarguil <adrien.mazarguil at 6wind.com
> wrote:

> Hi all (replying below)
>
> On Mon, May 06, 2013 at 09:28:33AM -0400, Han, Dongsu wrote:
> > Sounds good. With the two bug fixes I submitted txonly now runs
> perfectly.
> > Thanks!
> > -Dongsu
> > On May 6, 2013 8:47 AM, "Thomas Monjalon" <thomas.monjalon at 6wind.com>
> wrote:
> >
> > > Hi Dongsu Han,
> > >
> > > I think your fix is right.
> > > I've just removed tx_mbuf_alloc() and directly called
> rte_pktmbuf_alloc()
> > > instead.
> > > Is it OK for you ?
> > > Could you also review this (modified) description ?
> [...]
>
> While using rte_pktmbuf_alloc() is the correct fix, it's much slower than
> __rte_mbuf_raw_alloc() due to the unnecessary call to rte_pktmbuf_reset().
>
> Since testpmd is often used for performance testing, we should consider a
> wrapper function calling __rte_mbuf_raw_alloc() directly instead, as in
> rte_rxmbuf_alloc() implemented in igb and ixgbe PMDs.
>
> --
> Adrien Mazarguil
> 6WIND
> _______________________________________________
> dev mailing list
> dev at dpdk.org
> http://dpdk.org/ml/listinfo/dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://dpdk.org/ml/archives/dev/attachments/20130506/344f25a4/attachment.html>


More information about the dev mailing list