[dpdk-dev] [PATCH v2 1/2] pci: do not check BAR0 mapping

Thomas Monjalon thomas.monjalon at 6wind.com
Tue Sep 17 12:21:09 CEST 2013


From: David Marchand <david.marchand at 6wind.com>

Since DPDK 1.4, bars mapping is checked and prevent from initializing
drivers which do not use igb_uio mapping.
There is no need to check for bars mapping, especially BAR0 is not required.
If bars mapping failed, then pci_uio_map_resource will fail and we won't reach
this check. So get rid of BAR0 check.

Signed-off-by: David Marchand <david.marchand at 6wind.com>
Acked-by: Stephen Hemminger <shemminger at vyatta.com>
---
 lib/librte_eal/linuxapp/eal/eal_pci.c |    9 ---------
 1 file changed, 9 deletions(-)

diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c
index 5c7f814..3913c65 100644
--- a/lib/librte_eal/linuxapp/eal/eal_pci.c
+++ b/lib/librte_eal/linuxapp/eal/eal_pci.c
@@ -963,15 +963,6 @@ rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr, struct rte_pci_device *d
 			return -1;
 #endif
 
-		/* We always should have BAR0 mapped */
-		if (rte_eal_process_type() == RTE_PROC_PRIMARY && 
-			dev->mem_resource[0].addr == NULL) {
-			RTE_LOG(ERR, EAL,
-				"%s(): BAR0 is not mapped\n",
-				__func__);
-			return (-1);
-		}
- 
 		/* reference driver structure */
 		dev->driver = dr;
 
-- 
1.7.10.4



More information about the dev mailing list