[dpdk-dev] [PATCH 0/4] RX/TX queue start/stop enhancement

Thomas Monjalon thomas.monjalon at 6wind.com
Mon Aug 25 16:39:40 CEST 2014

> This patch mainly includes 2 changes. One is in testpmd to add command
> testing specific RX/TX queue start/stop in Port X. Another change is in
> i40e, which implemented rx/tx_queue_start/stop in both PF and VF driver.
> In the meanwhile, support field start_rx_per_q in i40e_dev_rx_queue_setup
> and start_tx_per_q in i40e_dev_tx_queue_setup.
> Chen Jing D(Mark) (4):
>   testpmd: add command to start/stop specfic queue
>   i40e: PF Add support for per-queue start/stop
>   i40e: PF driver to support RX/TX config paramter
>   i40e: VF driver to support per-queue RX/TX start/stop

Applied for version 1.7.1.

The commit logs and comments in the patches had some typos and sentences
difficult to read. For next patches, I'd prefer simpler sentences.
I'm french so I know how it's difficult to write clear english text and
I think it's even harder for a chinese.
By the way, I see that Konstantin reviewed the patch, so I assume he checked
the code but he probably forgot to check comments.

Please understand that my comment is not specifically about you (author or
reviewer), but it's an example of what I've seen many times before.
I try to fix or reword them, especially in commit logs. But it would make
things easier if everyone could make an effort about typos and english writing.


More information about the dev mailing list