[dpdk-dev] [PATCH 01/11] ixgbe: clean log messages

Stephen Hemminger stephen at networkplumber.org
Wed Aug 27 20:06:57 CEST 2014

On Wed, 27 Aug 2014 08:53:46 -0500
Jay Rolette <rolette at infiniteio.com> wrote:

> The updated output is definitely an improvement, but if you'll go with the
> first solution you described (adding \n in the log macro), it works much
> better for products using DPDK. For developer use, I think it ends up being
> a wash either way.

Also for driver consistency, all drivers must do the same thing. I.e the PMD_INIT_LOG
macro should either add or not add newline in the same way in all drivers.
I fixed virtio and vmxnet3 by just taking extra newlines out of messages
and leaving the macro alone.

More information about the dev mailing list