[dpdk-dev] [PATCH 4/6] bond: free mbufs if transmission fails in bonding tx_burst functions
thomas.monjalon at 6wind.com
Fri Aug 29 17:36:48 CEST 2014
Your patchset is pending for an answer to this comment.
2014-08-20 15:54, Sanford, Robert:
> I have a problem with the TX-burst logic of this patch. I believe that for
> packets that we *don't* enqueue to the device, we should *NOT* free them.
> The API expects that the caller will free them or try again to send them.
> Here is one way to accomplish selective freeing: Move mbuf pointers of
> packets successfully enqueued, to the beginning of the caller's mbuf
> vector; move mbuf pointers of packets not enqueued, to the end of the
> caller's mbuf list. Although possibly re-ordered, the caller will be able
> to free/resend all (and only) mbufs that we failed to enqueue.
More information about the dev