[dpdk-dev] [PATCH] enic: fix warnings

Thomas Monjalon thomas.monjalon at 6wind.com
Wed Dec 3 16:05:16 CET 2014


2014-12-03 14:52, Sujith Sankar:
> 
> On 02/12/14 8:29 pm, "Thomas Monjalon" <thomas.monjalon at 6wind.com> wrote:
> 
> >A lot of warnings were not seen because $(WERROR_FLAGS) was not set
> >in the Makefile. But they appear with toolchains that enforce more checks.
> >
> >-Wno-deprecated seems useless.
> >-Wno-strict-aliasing is added to avoid false positives.
> >
> >This patch cleans up unused variable, unused functions, wrong types,
> >static declarations, etc. A lot of functions have unused parameters;
> >it suggests that more clean-up could be needed.
> 
> I shall look at it when I pull these changes to my repo.
> What other toolchains did you check with?

It's tested with many distributions, example CentOS 6.
But adding the warnings as in this patch should be enough to test with
any toolchain.

-- 
Thomas


More information about the dev mailing list