[dpdk-dev] mk: fix LDFLAGS for shared lib

Neil Horman nhorman at tuxdriver.com
Mon Dec 8 16:01:54 CET 2014


On Wed, Dec 03, 2014 at 11:33:54PM +0000, Hiroshi Shimamoto wrote:
> From: Hiroshi Shimamoto <h-shimamoto at ct.jp.nec.com>
> 
> Only CPU_LDFLAGS is used in mk/rte.sharelib.mk.
> It should be LDFLAGS to build the library with correct linkage options.
> 
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto at ct.jp.nec.com>
> Reviewed-by: Hayato Momma <h-momma at ce.jp.nec.com>
> 
> ---
> mk/rte.sharelib.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mk/rte.sharelib.mk b/mk/rte.sharelib.mk
> index c0a811a..df6c268 100644
> --- a/mk/rte.sharelib.mk
> +++ b/mk/rte.sharelib.mk
> @@ -45,7 +45,7 @@ sharelib: $(LIB_ONE) FORCE
>  
>  OBJS = $(wildcard $(RTE_OUTPUT)/build/lib/*.o)
>  
> -O_TO_S = $(LD) $(CPU_LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE)
> +O_TO_S = $(LD) $(LDFLAGS) -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE)
>  O_TO_S_STR = $(subst ','\'',$(O_TO_S)) #'# fix syntax highlight
>  O_TO_S_DISP = $(if $(V),"$(O_TO_S_STR)","  LD $(@)")
>  O_TO_S_CMD = "cmd_$@ = $(O_TO_S_STR)"

Does this continue to work on cross compiled arches (32 bit on 64 bit systems
and vice versa)?  I have this recollection that something in CPU_LDFLAGS was
needed
Neil



More information about the dev mailing list