[dpdk-dev] [PATCH 02/11] devices-args: introduce rte_devargs in eal

Stephen Hemminger stephen at networkplumber.org
Fri Feb 28 22:39:29 CET 2014


On Fri, 28 Feb 2014 18:25:41 +0100
Olivier Matz <olivier.matz at 6wind.com> wrote:

> 	switch (devargs->type) {
> +		case RTE_DEVTYPE_WHITELISTED_PCI:
> +		case RTE_DEVTYPE_BLACKLISTED_PCI:
> +			/* try to parse pci identifier */
> +			if (eal_parse_pci_BDF(buf, &devargs->pci.addr) != 0 &&
> +				eal_parse_pci_DomBDF(buf, &devargs->pci.addr) != 0) {
> +				RTE_LOG(ERR, EAL,
> +					"invalid PCI identifier <%s>\n", buf);
> +				free(devargs);
> +				return -1;
> +			}
> +			break;

Minor nit. please align case with switch().
The DPDK in general follows Linux coding style.
In fact, I have run the code through checkpatch to find style issues.


More information about the dev mailing list