[dpdk-dev] Loop back mode of the KNI

Thomas Monjalon thomas.monjalon at 6wind.com
Fri Jan 17 16:35:37 CET 2014


17/01/2014 15:28, Zhang, Helin:
> The final fix for that could be like below.
> 
> --- a/lib/librte_eal/linuxapp/kni/kni_net.c
> +++ b/lib/librte_eal/linuxapp/kni/kni_net.c
> @@ -311,7 +311,6 @@ kni_net_rx_lo_fifo_skb(struct kni_dev *kni)
>                         skb_reserve(skb, 2);
>                         memcpy(skb_put(skb, len), data_kva, len);
>                         skb->dev = dev;
> -                       skb->protocol = eth_type_trans(skb, dev);
>                         skb->ip_summed = CHECKSUM_UNNECESSARY;
>                         dev_kfree_skb(skb);
>                 }
> @@ -327,7 +326,6 @@ kni_net_rx_lo_fifo_skb(struct kni_dev *kni)
>                         skb_reserve(skb, 2);
>                         memcpy(skb_put(skb, len), data_kva, len);
>                         skb->dev = dev;
> -                       skb->protocol = eth_type_trans(skb, dev);
>                         skb->ip_summed = CHECKSUM_UNNECESSARY;
> 
>                         kni->stats.rx_bytes += len;

Thanks for sharing.
Please, could you send a real patch with title, detailed explanation and 
sign-off as suggested in http://dpdk.org/dev#send ?
We should integrate such fix as soon as possible in the current branch in 
order to provide better user experience.

-- 
Thomas


More information about the dev mailing list