[dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf

Stephen Hemminger stephen at networkplumber.org
Tue Jun 24 19:54:27 CEST 2014


On Tue, 24 Jun 2014 17:39:52 +0000
"Richardson, Bruce" <bruce.richardson at intel.com> wrote:

> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen Hemminger
> > Sent: Tuesday, June 24, 2014 9:03 AM
> > To: dev at dpdk.org
> > Subject: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf
> > 
> > The function rte_snprintf serves no useful purpose. It is the
> > same as snprintf() for all valid inputs. Just remove it and
> > replace all uses in current code.
> > 
> > Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> > 
> 
> NAK to this as is.
> Approve of replacing all instance of the rte_snprintf function with the standard version in all our code and libraries.
> However, rather than just removing the function completely, I think we should just flag the function as deprecated initially, and then later on look to remove it completely.
> 
> /Bruce

I want to get it out now rather than some 2 year life cycle.
The issue was discussed and marking it as deprecated breaks the build.
Alternate is removing all instances and adding:

#define rte_snprintf	snprintf

in header file for user compatiablity.


More information about the dev mailing list