[dpdk-dev] [PATCH 01/15 v2] makefiles: Fixed -share command line option error

Neil Horman nhorman at tuxdriver.com
Fri May 2 13:09:27 CEST 2014


On Wed, Apr 30, 2014 at 01:42:12AM +0200, Thomas Monjalon wrote:
> 2014-04-16 09:51, Neil Horman:
> > The shared libraries built with the current makefile set produce static
> > libraries rather than actual shared objects.  This is due to several missing
> > options that are required to correctly build shared objects using ld, as
> > well as a mis-specified -share option (which should be -shared). Switching
> > to the use of CC rather than LD and fixing the -shared option corrects
> > these problems and builds the DSOs correctly.
> > 
> > Signed-off-by: Neil Horman <nhorman at tuxdriver.com>
> 
> Applied for version 1.6.0r2.
> 
> Thanks
> -- 
> Thomas
> 

So, I just went and looked at 1.6.0r2 and noted that you applied this patch, but
the rest of the series is still missing.  This is what I was talking about
earlier when I said you weren't applying patch series atomically.  It makes it
impossible to have any clue what the upstream development head is going to look
like.  On top of that, since you're clearly integrating other changes ahead of
this, theres every likelyhood the rest of my v5 series won't apply.

the v5 series has sat out here for a few weeks now without comment. If there
aren't any objections to it, apply it.  Whats the problem here?  I'm not going
to package the DPDK until this series (or the functionality it offers) is in
place.

Neil



More information about the dev mailing list