[dpdk-dev] [PATCH RFC] eal: change core mask input format

Burakov, Anatoly anatoly.burakov at intel.com
Fri May 23 11:02:16 CEST 2014

Hi Thomas,

> I don't understand what would be improved by adding a new parameter.
> I think being able to handle the 2 syntaxes within the same option is nice.

Well, -c option has been handling everything as hex since forever. Our own documentation usually has coremasks without the 0x prefix. That means that there's probably a lot of legacy code (including our own internal validation code, and probably a lot of customers' code too) that depend on this behavior and that will fail in an unobvious way (e.g. you specified -c 3, that gave you cores 0,1 previously, now it gives you core 3). So I personally would much prefer leaving coremask as a *coremask* (e.g. a hex mask of cores), and add a new parameter to have a core *list* that would be interchangeable with coremask.

Best regards,
Anatoly Burakov
DPDK SW Engineer

More information about the dev mailing list