[dpdk-dev] [PATCH v2 03/16] Rename RTE_PCI_DRV_NEED_IGB_UIO to RTE_PCI_DRV_NEED_MAPPING

Xu, HuilongX huilongx.xu at intel.com
Tue May 27 04:39:00 CEST 2014


Rename the RTE_PCI_DRV_NEED_IGB_UIO to be more generic,
retain old macro for backwards compatibility. Probably should
be removed in one of the next releases.

Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>
Test-by: HuilongX Xu <huilongx.xu at intel.com>
Compile pass
     >>Compile OS: FC20 x86_64
     >>Kernel version: 3.13.6-200
     >>GCC version: 4.8.2
     >>Server: Crownpass
---
app/test/test_pci.c                     |    4 ++--
lib/librte_eal/bsdapp/eal/eal_pci.c     |    2 +-
lib/librte_eal/common/include/rte_pci.h |    6 ++++--
lib/librte_pmd_e1000/em_ethdev.c        |    2 +-
lib/librte_pmd_e1000/igb_ethdev.c       |    4 ++--
lib/librte_pmd_ixgbe/ixgbe_ethdev.c     |    4 ++--
lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c |    2 +-
7 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/app/test/test_pci.c b/app/test/test_pci.c
index 6908d04..fad118e 100644
--- a/app/test/test_pci.c
+++ b/app/test/test_pci.c
@@ -63,7 +63,7 @@ static int my_driver_init(struct rte_pci_driver *dr,
                                                 struct rte_pci_device *dev);
 /*
- * To test cases where RTE_PCI_DRV_NEED_IGB_UIO is set, and isn't set, two
+ * To test cases where RTE_PCI_DRV_NEED_MAPPING is set, and isn't set, two
  * drivers are created (one with IGB devices, the other with IXGBE devices).
  */
@@ -91,7 +91,7 @@ struct rte_pci_driver my_driver = {
               .name = "test_driver",
               .devinit = my_driver_init,
               .id_table = my_driver_id,
-              .drv_flags = RTE_PCI_DRV_NEED_IGB_UIO,
+             .drv_flags = RTE_PCI_DRV_NEED_MAPPING,
};
 struct rte_pci_driver my_driver2 = {
diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c
index 94ae461..eddbd2f 100644
--- a/lib/librte_eal/bsdapp/eal/eal_pci.c
+++ b/lib/librte_eal/bsdapp/eal/eal_pci.c
@@ -474,7 +474,7 @@ rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr, struct rte_pci_device *d
                                               return 0;
                               }
-                              if (dr->drv_flags & RTE_PCI_DRV_NEED_IGB_UIO) {
+                             if (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING) {
                                               /* map resources for devices that use igb_uio */
                                               if (pci_uio_map_resource(dev) < 0)
                                                               return -1;
diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h
index c793773..84d7b42 100644
--- a/lib/librte_eal/common/include/rte_pci.h
+++ b/lib/librte_eal/common/include/rte_pci.h
@@ -190,12 +190,14 @@ struct rte_pci_driver {
               uint32_t drv_flags;                     /**< Flags contolling handling of device. */
};
-/** Device needs igb_uio kernel module */
-#define RTE_PCI_DRV_NEED_IGB_UIO 0x0001
+/** Device needs PCI BAR mapping (done with either IGB_UIO or VFIO) */
+#define RTE_PCI_DRV_NEED_MAPPING 0x0001
/** Device driver must be registered several times until failure */
#define RTE_PCI_DRV_MULTIPLE 0x0002
/** Device needs to be unbound even if no module is provided */
#define RTE_PCI_DRV_FORCE_UNBIND 0x0004
+/** Retain the old name for backwards-compatibility */
+#define RTE_PCI_DRV_NEED_IGB_UIO RTE_PCI_DRV_NEED_MAPPING
 /**< Internal use only - Macro used by pci addr parsing functions **/
#define GET_PCIADDR_FIELD(in, fd, lim, dlm)                   \
diff --git a/lib/librte_pmd_e1000/em_ethdev.c b/lib/librte_pmd_e1000/em_ethdev.c
index 755e474..f3575d5 100644
--- a/lib/librte_pmd_e1000/em_ethdev.c
+++ b/lib/librte_pmd_e1000/em_ethdev.c
@@ -279,7 +279,7 @@ static struct eth_driver rte_em_pmd = {
               {
                               .name = "rte_em_pmd",
                               .id_table = pci_id_em_map,
-                              .drv_flags = RTE_PCI_DRV_NEED_IGB_UIO,
+                             .drv_flags = RTE_PCI_DRV_NEED_MAPPING,
               },
               .eth_dev_init = eth_em_dev_init,
               .dev_private_size = sizeof(struct e1000_adapter),
diff --git a/lib/librte_pmd_e1000/igb_ethdev.c b/lib/librte_pmd_e1000/igb_ethdev.c
index c7b3926..b49db52 100644
--- a/lib/librte_pmd_e1000/igb_ethdev.c
+++ b/lib/librte_pmd_e1000/igb_ethdev.c
@@ -600,7 +600,7 @@ static struct eth_driver rte_igb_pmd = {
               {
                               .name = "rte_igb_pmd",
                               .id_table = pci_id_igb_map,
-                              .drv_flags = RTE_PCI_DRV_NEED_IGB_UIO,
+                             .drv_flags = RTE_PCI_DRV_NEED_MAPPING,
               },
               .eth_dev_init = eth_igb_dev_init,
               .dev_private_size = sizeof(struct e1000_adapter),
@@ -613,7 +613,7 @@ static struct eth_driver rte_igbvf_pmd = {
               {
                               .name = "rte_igbvf_pmd",
                               .id_table = pci_id_igbvf_map,
-                              .drv_flags = RTE_PCI_DRV_NEED_IGB_UIO,
+                             .drv_flags = RTE_PCI_DRV_NEED_MAPPING,
               },
               .eth_dev_init = eth_igbvf_dev_init,
               .dev_private_size = sizeof(struct e1000_adapter),
diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
index e78c208..5354a3f 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
@@ -931,7 +931,7 @@ static struct eth_driver rte_ixgbe_pmd = {
               {
                               .name = "rte_ixgbe_pmd",
                               .id_table = pci_id_ixgbe_map,
-                              .drv_flags = RTE_PCI_DRV_NEED_IGB_UIO,
+                             .drv_flags = RTE_PCI_DRV_NEED_MAPPING,
               },
               .eth_dev_init = eth_ixgbe_dev_init,
               .dev_private_size = sizeof(struct ixgbe_adapter),
@@ -944,7 +944,7 @@ static struct eth_driver rte_ixgbevf_pmd = {
               {
                               .name = "rte_ixgbevf_pmd",
                               .id_table = pci_id_ixgbevf_map,
-                              .drv_flags = RTE_PCI_DRV_NEED_IGB_UIO,
+                             .drv_flags = RTE_PCI_DRV_NEED_MAPPING,
               },
               .eth_dev_init = eth_ixgbevf_dev_init,
               .dev_private_size = sizeof(struct ixgbe_adapter),
diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c
index 8259cfe..a08c2bf 100644
--- a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c
+++ b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c
@@ -267,7 +267,7 @@ static struct eth_driver rte_vmxnet3_pmd = {
               {
                               .name = "rte_vmxnet3_pmd",
                               .id_table = pci_id_vmxnet3_map,
-                              .drv_flags = RTE_PCI_DRV_NEED_IGB_UIO,
+                             .drv_flags = RTE_PCI_DRV_NEED_MAPPING,
               },
               .eth_dev_init = eth_vmxnet3_dev_init,
               .dev_private_size = sizeof(struct vmxnet3_adapter),
--
1.7.0.7


More information about the dev mailing list