[dpdk-dev] [PATCH v2 04/16] Make igb_uio compilation optional
Thomas Monjalon
thomas.monjalon at 6wind.com
Tue May 27 10:57:30 CEST 2014
Hi HuilongX,
(sorry, my previous email was sent before I finished writing it)
Thanks for testing patches.
In order to be more efficient next times, I have few comments.
2014-05-27 02:43, Xu, HuilongX:
> Currently, igb_uio is always compiled. Some Linux distribution may
> not want to include igb_uio by default, so we need to make sure that
> igb_uio compilation can be optional.
1) When replying to an email, there should be "> " in front of lines you have
not written. Here, it's not easy to see what you are replying.
> Signed-off-by: Anatoly Burakov
> <anatoly.burakov at intel.com<mailto:anatoly.burakov at intel.com>>
2) Your mailer is breaking the Signed-off line.
> Test-by: HuilongX Xu <huilongx.xu at intel.com<mailto:huilongx.xu at intel.com>>
3) If you do some tests (other than compiling), you should explain what are
the tests (command lines and environment).
> Compile pass
4) No need to notify that compilation is working. It's implicit (and
mandatory) when sending a patch.
> >>Compile OS: FC20 x86_64
> >>Kernel version: 3.13.6-200
> >>GCC version: 4.8.2
> >>Server: Crownpass
>
> ---
> config/defconfig_i686-default-linuxapp-gcc | 1 +
> config/defconfig_i686-default-linuxapp-icc | 1 +
> config/defconfig_x86_64-default-linuxapp-gcc | 1 +
> config/defconfig_x86_64-default-linuxapp-icc | 1 +
> lib/librte_eal/linuxapp/Makefile | 2 ++
> lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +-
> 6 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/config/defconfig_i686-default-linuxapp-gcc
> b/config/defconfig_i686-default-linuxapp-gcc index 14bd3d1..ea90f12 100644
> --- a/config/defconfig_i686-default-linuxapp-gcc
> +++ b/config/defconfig_i686-default-linuxapp-gcc
5) Please do not copy all the patch if you have nothing specific to say about
it.
Thanks for your help
--
Thomas
More information about the dev
mailing list