[dpdk-dev] [PATCH 06/12] mbuf: add functions to get the name of an ol_flag

Olivier MATZ olivier.matz at 6wind.com
Mon Nov 10 21:54:45 CET 2014


Hi Bruce,

Thank you for the review.

On 11/10/2014 06:29 PM, Bruce Richardson wrote:
>> +/**
>> + * Bit Mask to indicate what bits required for building TX context
> 
> I don't understand this first line - is it accidentally included?

Right, it's a mistake, I'll remove this line.

>> + * Get the name of a RX offload flag
>> + *
>> + * @param mask
>> + *   The mask describing the flag. Usually only one bit must be set.
>> + *   Several bits can be given if they belong to the same mask.
>> + *   Ex: PKT_TX_L4_MASK.
> TX mask given as an example for a function for RX flags is confusing.

I'll remove the last two lines of the description as there is no example
for RX flags.


Regards,
Olivier


More information about the dev mailing list