[dpdk-dev] [PATCH 05/12] mbuf: remove too specific PKT_TX_OFFLOAD_MASK definition
Olivier MATZ
olivier.matz at 6wind.com
Mon Nov 10 21:59:37 CET 2014
Hi Bruce,
On 11/10/2014 06:14 PM, Bruce Richardson wrote:
>> --- a/lib/librte_pmd_e1000/igb_rxtx.c
>> +++ b/lib/librte_pmd_e1000/igb_rxtx.c
>> @@ -400,7 +400,8 @@ eth_igb_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
>> ol_flags = tx_pkt->ol_flags;
>> vlan_macip_lens.f.vlan_tci = tx_pkt->vlan_tci;
>> vlan_macip_lens.f.l2_l3_len = tx_pkt->l2_l3_len;
>> - tx_ol_req = ol_flags & PKT_TX_OFFLOAD_MASK;
>> + tx_ol_req = ol_flags & (PKT_TX_VLAN_PKT | PKT_TX_IP_CKSUM |
>> + PKT_TX_L4_MASK);
>>
>
> Rather than make the change like this, might it be clearer just to copy-paste
> the macro definition into this file (perhaps as IGB_TX_OFFLOAD_MASK). Similarly
> with ixgbe below?
As this definition was used only once per PMD, I thought it was clearer
to remove the definition. But... someone did the same comment than
you internally, so I'll change it in next version!
Regards,
Olivier
More information about the dev
mailing list