[dpdk-dev] [PATCH] enicpmd: compilation error during inclusion of vfio.h

[Sujith Sankar (ssujith)]

On 28/11/14 1:54 am, "Thomas Monjalon" <thomas.monjalon at 6wind.com> wrote:

>2014-11-27 19:01, Thomas Monjalon:
>> 2014-11-27 22:44, Sujith Sankar:
>> > Inclusion of vfio.h was giving compilation errors if kernel version
>>is less
>> > than 3.6.0 and if RTE_EAL_VFIO was on in config.
>> > 
>> > Replaced inclusion of vfio.h with eal_vfio.h and replaced
>>RTE_EAL_VFIO with
>> > VFIO_PRESENT in enicpmd code.
>> 
>> You should add
>> Reported-by: Pawel Wodkowski <pawelx.wodkowski at intel.com>

I shall take care of this from now on.

>> 
>> > Signed-off-by: Sujith Sankar <ssujith at cisco.com>
>> [...]
>> >  CFLAGS += -I$(RTE_SDK)/lib/librte_hash/
>>-I$(RTE_SDK)/lib/librte_pmd_enic/vnic/
>> >  CFLAGS += -I$(RTE_SDK)/lib/librte_pmd_enic/
>> > +CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linuxapp/eal/
>> >  CFLAGS += -O3 -Wno-deprecated
>> 
>> I think -I$(RTE_SDK)/lib/librte_hash/ and
>>-I$(RTE_SDK)/lib/librte_eal/linuxapp/eal/
>> are not needed.
>> 
>> I'll fix it if you confirm.

You¹re right.

>
>Applied with above comments.

Thank you Thomas !

>
>-- 
>Thomas