[dpdk-dev] [PATCH] Pass verbose flag to kernel module

Thomas Monjalon thomas.monjalon at 6wind.com
Wed Oct 15 14:04:52 CEST 2014


Sergio,

I'd like to see a v2 patch with your explanations in commit log
and with a Signed-off-by.

> > -		CROSS_COMPILE=$(CROSS)
> > +		V=$(if $(V),1,0) CROSS_COMPILE=$(CROSS)

Minor nits:
- paren is not needed for one letter variable
- V option should go to the end to keep things sorted by importance

-               CROSS_COMPILE=$(CROSS)
+               CROSS_COMPILE=$(CROSS) V=$(if $V,1,0)

> Acked-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>

Please Pablo, do not give your ack if there is no Signed-off-by.
It's mandatory.

Thanks
-- 
Thomas


More information about the dev mailing list