[dpdk-dev] [PATCH] igb_ethdev.c: complete switches for i211 NC

Thomas Monjalon thomas.monjalon at 6wind.com
Wed Sep 24 19:38:29 CEST 2014


2014-09-10 01:28, Zhang, Helin:
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Sergey Mironov
> > Hi! I have got an update for my "i212 problem". First of all, I found that I have
> > made a mistake. My controller is named i211, not i212 :) Next, i211 controller is
> > controlled by the lib_pmd_e1000 driver.
> > Unfortunately, looks like it's support is pure. For example, igb_ethdev.c
> > contains function eth_igb_infos_get() which should set number of tx/rx queues
> > supported by the hardware. It contains huge [switch] but there is no i211 case!
> > That is why I see zeros every time I try to start this NC. Also, there are few
> > other places which mention i210, but not mention i211. I've attached a patch
> > which adds necessary
> > i211 support, but I didn't check it enough to say it is totally correct. For now I
> > see that it just able to send and receive some packets.
> > 
> > Could you please review/correct it?

The funny thing is that the file igb_rxtx.c seems to already support i211,
but not igb_ethdev.c. Thanks for fixing that.

> >  	if ((hw->mac.type == e1000_82576) || (hw->mac.type == e1000_82580) ||
> > -		(hw->mac.type == e1000_i350) || (hw->mac.type == e1000_i210)) {
> > +		(hw->mac.type == e1000_i350) || (hw->mac.type == e1000_i210) ||
> > +    (hw->mac.type == e1000_i211)) {

Wrong indent here.

> Reviewed-by: Helin Zhang <helin.zhang at intel.com>
> 
> Really good to have this patch of supporting i211! Thank you very much!

Acked and applied with indent fix.

Thanks
-- 
Thomas


More information about the dev mailing list