[dpdk-dev] [PATCH v3 0/5] Clean up pci uio implementations

Tetsuya Mukawa mukawa at igel.co.jp
Thu Apr 23 06:23:33 CEST 2015


On 2015/04/21 22:15, Iremonger, Bernard wrote:
>> -----Original Message-----
>> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
>> Sent: Friday, March 27, 2015 8:39 AM
>> To: dev at dpdk.org
>> Cc: Iremonger, Bernard; Richardson, Bruce; david.marchand at 6wind.com; Tetsuya Mukawa
>> Subject: [PATCH v3 0/5] Clean up pci uio implementations
>>
>> This patch set cleans up pci uio implementation. These clean up are for consolidating pci uio
>> implementation of linuxapp and bsdapp, and moving consolidated functions in eal common.
>> Because of above, this patch set tries to implement linuxapp and bsdapp almost same.
>> Actual consolidations will be done later patch set.
>>
>> PATCH v3 changes:
>>  - Squash patches related with pci_map_resource().
>>  - Free maps[].path to easy to understand.
>>    (Thanks to Iremonger, Bernard)
>>  - Close fds opened in this function.
>>  - Remove unused path variable from mapped_pci_resource structure.
>>
>> PATCH v2 changes:
>>  - Move 'if-condition' to later patch series.
>>  - Fix memory leaks of path.
>>  - Fix typos.
>>    (Thanks to David Marchand)
>>  - Fix commit title and body.
>>  - Fix pci_map_resource() to handle MAP_FAILED.
>>    (Thanks to Iremonger, Bernard)
>>
>> Changes:
>>  - This patch set is derived from below.
>>    "[PATCH v2] eal: Port Hotplug support for BSD"
>>  - Set cfg_fd as -1, when cfg_fd is closed.
>>    (Thanks to Iremonger, Bernard)
>>  - Remove needless coding style fixings.
>>  - Fix coding style of if-else condition.
>>    (Thanks to Richardson, Bruce)
>>
>>
>>
>> Tetsuya Mukawa (5):
>>   eal: Fix coding style of eal_pci.c and eal_pci_uio.c
>>   eal: Close file descriptor of uio configuration
>>   eal: Fix memory leaks and needless increment of pci_map_addr
>>   eal/bsdapp: Change names of pci related data structure
>>   eal: Fix uio mapping differences between linuxapp and bsdapp
>>
>>  lib/librte_eal/bsdapp/eal/eal_pci.c        | 166 +++++++++++++++++------------
>>  lib/librte_eal/linuxapp/eal/eal_pci_init.h |   1 -
>>  lib/librte_eal/linuxapp/eal/eal_pci_uio.c  |  91 +++++++++-------
>>  3 files changed, 154 insertions(+), 104 deletions(-)
>>
>> --
>> 1.9.1
> Series
> Acked-by: Bernard Iremonger <bernard.iremonger at intel.com>
Hi Bernard,

Thanks for your checking.
It seems I need to rebase this patches for latest matser branch.
So I will update and submit it soon.

Regards,
Tetsuya


More information about the dev mailing list