[dpdk-dev] [PATCH 03/18] i40e: adjustment of register definitions and relevant

Thomas Monjalon thomas.monjalon at 6wind.com
Mon Apr 27 19:16:35 CEST 2015


2015-04-20 16:22, Helin Zhang:
> More register definitions and their relevant masks are added
> publically. Also few useless macros are deleted.
> 
> Signed-off-by: Helin Zhang <helin.zhang at intel.com>
> ---
>  lib/librte_pmd_i40e/i40e/i40e_register.h | 1981 +++++++++++++++++++++++++++++-

All these values are not used in the driver, right?

> --- a/lib/librte_pmd_i40e/i40e_ethdev.c
> +++ b/lib/librte_pmd_i40e/i40e_ethdev.c
> @@ -1269,9 +1269,6 @@ i40e_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
>  			    I40E_GLPRT_BPTCL(hw->port),
>  			    pf->offset_loaded, &os->eth.tx_broadcast,
>  			    &ns->eth.tx_broadcast);
> -	i40e_stat_update_32(hw, I40E_GLPRT_TDPC(hw->port),
> -			    pf->offset_loaded, &os->eth.tx_discards,
> -			    &ns->eth.tx_discards);

The relation between this deletion and the rest of the patch is weird.



More information about the dev mailing list