[dpdk-dev] [PATCH v6 4/9] ethdev: remove HW specific stats in stats structs
maryam.tahhan at intel.com
Wed Aug 19 14:53:46 CEST 2015
> From: Olivier MATZ [mailto:olivier.matz at 6wind.com]
> Sent: Monday, August 17, 2015 3:54 PM
> To: Tahhan, Maryam; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v6 4/9] ethdev: remove HW specific stats in
> stats structs
> Hi Maryam,
> On 07/15/2015 03:11 PM, Maryam Tahhan wrote:
> > Remove non generic stats in rte_stats_strings and mark the relevant
> > fields in struct rte_eth_stats as deprecated.
> > Signed-off-by: Maryam Tahhan <maryam.tahhan at intel.com>
> > ---
> > doc/guides/rel_notes/abi.rst | 12 ++++++++++++
> > lib/librte_ether/rte_ethdev.c | 9 ---------
> > lib/librte_ether/rte_ethdev.h | 30 ++++++++++++++++++++----------
> > 3 files changed, 32 insertions(+), 19 deletions(-)
> > diff --git a/doc/guides/rel_notes/abi.rst
> > b/doc/guides/rel_notes/abi.rst index 931e785..d5bf625 100644
> > --- a/doc/guides/rel_notes/abi.rst
> > +++ b/doc/guides/rel_notes/abi.rst
> > @@ -24,3 +24,15 @@ Deprecation Notices
> > * The Macros RTE_HASH_BUCKET_ENTRIES_MAX and
> RTE_HASH_KEY_LENGTH_MAX are
> > deprecated and will be removed with version 2.2.
> > +
> > +* The following fields have been deprecated in rte_eth_stats:
> > + * uint64_t imissed
> > + * uint64_t ibadcrc
> > + * uint64_t ibadlen
> > + * uint64_t imcasts
> > + * uint64_t fdirmatch
> > + * uint64_t fdirmiss
> > + * uint64_t tx_pause_xon
> > + * uint64_t rx_pause_xon
> > + * uint64_t tx_pause_xoff
> > + * uint64_t rx_pause_xoff
> Looking again at this patch, I'm wondering if "imissed" should be kept instead
> of beeing deprecated. I think it could be useful to differentiate ierrors from
> imissed, and it's not a hw-specific statistic. What do you think?
> One more comment: it seems these fields are marked as deprecated but they
> are still used on other drivers (e1000, i40e, ...).
I can remove the deprecated status for imissed to leave the differentiation between errors and missed packets.
igb and i40e will be updated soon to reflect this. I marked them as deprecated to deter their use in the future. Older instances/use will need to be resolved.
More information about the dev