[dpdk-dev] [PATCH] qos_meter: Fix compilation with APP_MODE_FWD
john.mcnamara at intel.com
Tue Aug 25 15:34:50 CEST 2015
> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, August 25, 2015 1:37 PM
> To: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] qos_meter: Fix compilation with APP_MODE_FWD
> > --- a/examples/qos_meter/main.h
> > +++ b/examples/qos_meter/main.h
> > #if APP_MODE == APP_MODE_FWD
> > -#define FUNC_METER(a,b,c,d) color, flow_id=flow_id, pkt_len=pkt_len,
> > time=time
> > +#define FUNC_METER(a,b,c,d) input_color, flow_id=flow_id,
> > +pkt_len=pkt_len, time=time
> This patch should not be accepted to discourage build-time options.
> Patch for run-time option is welcome.
The patch is fixing a compilation issue, which seems reasonable. It isn't introducing a build time option, it is merely fixing an typo in an existing one.
Yes, it would be better not to have this build time option (in which case the issue would have been found sooner) but that isn't the responsibility of the person submitting this patch.
That is something that should be pushed back to the author/maintainer.
In the meantime this patch is still valid and should be applied.
More information about the dev