[dpdk-dev] [PATCH v2] examples/vhost: fix statistics error

[Tan, Jianfeng]

> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Thursday, December 3, 2015 2:18 PM
> To: Tan, Jianfeng
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] examples/vhost: fix statistics error
> 
> On Thu, Dec 03, 2015 at 06:01:33AM +0800, Jianfeng Tan wrote:
> > This issue was discovered under the case of software vm2vm
> > fowarding. When pkts are received from virtio device 0 and
> > tx_route to virtio device 1, tx of device 0 is not updated.
> >
> > To fix this problem, we check each rx/tx branch to update
> > stats. Besides, the stats are printed at a separated thread,
> > so we design a mechanism to make sure unreasonable data will
> > not show.
> 
> Fixing statistics for vm2vm case and designing a mechanism
> to make sure unreasonable data will not sure are two different
> things: they should be done in two different patches, but not
> one.
> 
> So, again, please do not mix two (or more) things in one patch.

Exactly, I found this problem when I just send out v2. Sorry for the spam.
Pls review v3.

Thanks,
Jianfeng
> 
> 	--yliu