[dpdk-dev] [PATCH] eal: don't crash if one pci device fails
Bruce Richardson
bruce.richardson at intel.com
Thu Dec 3 11:02:07 CET 2015
On Wed, Dec 02, 2015 at 05:38:40PM -0800, Stephen Hemminger wrote:
> If there is a failure to setup one pci device, there maybe other
> devices that can be initialized. Don't call rte_exit which
> is a forced crash, pass the error back to the
> application to decide what it wants to do.
>
> Might be good idea to return a positive value for the
> number of devices found, but that would break ABI.
>
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
The return value from this function gets passed back to rte_eal_init() where
it will still cause an application to terminate. Therefore, I think the
commit message is a little misleading.
Otherwise all looks ok to me. Will help weed out multiple device failures on
a single pass too.
/Bruce
More information about the dev
mailing list