[dpdk-dev] [PATCH 3/6] virtio: armv7/v8: Introdice api to emulate x86-style of PCI/ISA ioport access

Santosh Shukla sshukla at mvista.com
Tue Dec 8 16:35:54 CET 2015


On Mon, Dec 7, 2015 at 10:39 PM, Stephen Hemminger <
stephen at networkplumber.org> wrote:

> On Fri,  4 Dec 2015 23:05:16 +0530
> Santosh Shukla <sshukla at mvista.com> wrote:
>
> > +#if defined(RTE_ARCH_ARM64)
> > +     uint64_t    io_base;
> > +#else /* !ARM64 */
> >       uint32_t    io_base;
> > +#endif
>
> Is there a typedef that could be used instead of having #ifdef clutter?
>

I am not sure if there is any for arm. Can you pl. point me any code
snippet (perhaps arch specific) example?

BTW: I am thinking to change io_base to word_size {arch size aligned} in v2
patch revision and By doing that we don't need care for ifdefs. Currently
uin32_t hold good for io;s ranging from 0 to 65535.

Wanted to keep something like below

unsigned long io_base;

for 32 bit case - 4 byte
for 64 bit case - 8 byte.

Does that make sense?


More information about the dev mailing list