[dpdk-dev] [PATCH v1 2/2] examples/l2fwd-keepalive: Fix integer overflow

Remy Horton remy.horton at intel.com
Thu Dec 10 10:50:07 CET 2015


Fix Coverity warning with potential 32-bit integer multiplication overflow
where final result is expected to be 64-bit.

>>> CID 120144 (#1 of 1): Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN)

Fixes: e64833f2273a ("examples/l2fwd-keepalive: add sample application")

Signed-off-by: Remy Horton <remy.horton at intel.com>
---
 examples/l2fwd-keepalive/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/l2fwd-keepalive/main.c b/examples/l2fwd-keepalive/main.c
index 8d7b09e..f4d52f2 100644
--- a/examples/l2fwd-keepalive/main.c
+++ b/examples/l2fwd-keepalive/main.c
@@ -471,7 +471,7 @@ l2fwd_parse_args(int argc, char **argv)
 		/* timer period */
 		case 'T':
 			timer_period = l2fwd_parse_timer_period(optarg)
-				* 1000 * TIMER_MILLISECOND;
+				* (int64_t)(1000 * TIMER_MILLISECOND);
 			if (timer_period < 0) {
 				printf("invalid timer period\n");
 				l2fwd_usage(prgname);
-- 
1.9.3



More information about the dev mailing list