[dpdk-dev] [PATCH] scripts: fix relpath.sh output when $prefix is set in environment

Panu Matilainen pmatilai at redhat.com
Fri Dec 11 13:44:23 CET 2015


When relpath.sh is called from install target with prefix set, eg
"make install DESTDIR=/tmp/dpdk-root prefix=/usr", the prefix
from the environment leaks to relpath.sh internal helper variable and
causes incorrect symlinks to be generated in sdk $(targetdir):

   include -> /usr../../../include/dpdk
   lib -> /usr../../../lib

Initialize the local variable to empty to avoid side-effects from
environment.

Signed-off-by: Panu Matilainen <pmatilai at redhat.com>
---
 scripts/relpath.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/scripts/relpath.sh b/scripts/relpath.sh
index 7d2f48f..4ff4671 100755
--- a/scripts/relpath.sh
+++ b/scripts/relpath.sh
@@ -61,6 +61,8 @@ right2=${REL2#*/}
 prev_right2=$REL2
 prev_left2=
 
+prefix=
+
 while [ "${right1}" != "" -a "${right2}" != "" ]; do
 
 	if [ "$left1" != "$left2" ]; then
-- 
2.5.0



More information about the dev mailing list