[dpdk-dev] [PATCH 18/18] Change mk/rte.app.mk to add fm10k lib into link

[Thomas Monjalon]

2015-02-02 08:10, Chen, Jing D:
> From: Neil Horman [mailto:nhorman at tuxdriver.com]
> > This patch should be merged with patch 17, and patch 2, and placed at the
> > end of
> > your series to avoid a FTBFS issue
> 
> My rationale is to make every single patch not to break the compile. So, I'd like to
> add the binary library into compile and link in last 2 patches, after all the actual code
> are patched.  For Patch 2, I think you are right, maybe a better way is to move it as 
> patch "16". 
> 
> But I'm not sure whether I should merge these 3 together. You know, somebody may
> not happy to see the changes in different directory to appear in single patch.

No, I think you are wrong. You can have modifications in different directories
in a patch. A patch must be atomic (one addition/change/feature at a time) and
buildable. In your case, it would be best to have a patch allowing compilation
of fm10k after the patch for "register". So it would mean we are able to test
the minimal driver and each feature added after.

Thanks
-- 
Thomas