[dpdk-dev] [PATCH 12/20] testpmd: introduce parse_vxlan in csum fwd engine

Olivier MATZ olivier.matz at 6wind.com
Mon Feb 2 13:42:01 CET 2015


Hi Jijiang,

On 02/02/2015 02:49 AM, Liu, Jijiang wrote:
>> +/* Parse a vxlan header */
>> +static void
>> +parse_vxlan(struct udp_hdr *udp_hdr, struct testpmd_offload_info *info,
>> +	uint64_t mbuf_olflags)
>> +{
>> +	struct ether_hdr *eth_hdr;
>> +
>> +	/* check udp destination port, 4789 is the default vxlan port
>> +	 * (rfc7348) or that the rx offload flag is set (i40e only
>> +	 * currently) */
>> +	if (udp_hdr->dst_port != _htons(4789) &&
>> +		(mbuf_olflags & (PKT_RX_TUNNEL_IPV4_HDR |
>> +			PKT_RX_TUNNEL_IPV6_HDR)) != 0)
> 
> It seems that there is a bug, which is mbuf_olflags check.
> It should be 
> (mbuf_olflags & (PKT_RX_TUNNEL_IPV4_HDR |
> 			PKT_RX_TUNNEL_IPV6_HDR)) == 0).

That's correct. Thank you for checking this carefully. I'll
fix this in a v2 patch.

Regards,
Olivier


More information about the dev mailing list