[dpdk-dev] [PATCH] mk: fix missing link of librte_vhost in shared, non-combined config

Gonzalez Monroy, Sergio sergio.gonzalez.monroy at intel.com
Wed Feb 11 11:51:27 CET 2015


Hi Panu,

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen
> Sent: Wednesday, February 11, 2015 8:53 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] mk: fix missing link of librte_vhost in shared,
> non-combined config
> 
> When building shared, non-combined library, librte_vhost does not get
> linked in, causing among other things vhost example to fail building to do
> undefined symbols on linkage.
> 
> Signed-off-by: Panu Matilainen <pmatilai at redhat.com>
> ---
>  mk/rte.app.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk index 95dbb0b..55d989e 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -125,6 +125,10 @@ LDLIBS += -lm
>  LDLIBS += -lrt
>  endif
> 
> +ifeq ($(CONFIG_RTE_LIBRTE_VHOST), y)
> +LDLIBS += -lrte_vhost
> +endif
> +
>  endif # ! CONFIG_RTE_BUILD_COMBINE_LIBS
> 
>  ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y)
> --
> 2.1.0

I think that vhost is being linked in the wrong place (plugins section).
The plugins only get linked when building static libraries.
I think the patch should also remove vhost from the plugins section.

Regards,
Sergio


More information about the dev mailing list