[dpdk-dev] [PATCH 6/6] examples: remove unneeded casts
Bruce Richardson
bruce.richardson at intel.com
Thu Feb 19 16:02:03 CET 2015
On Sat, Feb 14, 2015 at 09:59:10AM -0500, Stephen Hemminger wrote:
> *alloc() routines return void * and therefore cast is not needed.
>
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> ---
> examples/kni/main.c | 4 ++--
> examples/l3fwd-acl/main.c | 4 ++--
> examples/vhost/main.c | 7 ++++---
> 3 files changed, 8 insertions(+), 7 deletions(-)
>
... <snip> ...
> diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> index 3a35359..a96b19f 100644
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -2592,9 +2592,10 @@ new_device (struct virtio_net *dev)
>
> }
>
> - vdev->regions_hpa = (struct virtio_memory_regions_hpa *) rte_zmalloc("vhost hpa region",
> - sizeof(struct virtio_memory_regions_hpa) * vdev->nregions_hpa,
> - RTE_CACHE_LINE_SIZE);
> + vdev->regions_hpa = rte_calloc("vhost hpa region",
> + sizeof(struct virtio_memory_regions_hpa),
> + vdev->nregions_hpa,
> + RTE_CACHE_LINE_SIZE);
I know functionally it probably doesn't make a difference, but I think your
"num" and "size" parameters are reversed here.
/Bruce
More information about the dev
mailing list