[dpdk-dev] [PATCH v1] afpacket: fix critical issue reported by klocwork

[Thomas Monjalon]

2015-02-25 00:57, Liang, Cunming:
> From: John W. Linville [mailto:linville at tuxdriver.com]
> > On Fri, Feb 20, 2015 at 11:19:59AM +0100, Thomas Monjalon wrote:
> > > 2015-02-12 17:08, Cunming Liang:
> > > > --- a/lib/librte_pmd_af_packet/rte_eth_af_packet.c
> > > > +++ b/lib/librte_pmd_af_packet/rte_eth_af_packet.c
> > > > @@ -439,13 +439,15 @@ rte_pmd_init_internals(const char *name,
> > > >  	size_t ifnamelen;
> > > >  	unsigned k_idx;
> > > >  	struct sockaddr_ll sockaddr;
> > > > -	struct tpacket_req *req;
> > > > +	struct tpacket_req *req = NULL;
> > >
> > > If *internals is set to NULL, there should be no case where req used
> > > and undefined.
> 
> [LCM] Agree, so that's why I add '*internals = NULL' below as well.
> > 
> > I agree -- it looks to me like req is protected by checking for
> > *internals == NULL.  I don't think this patch is necessary.
> 
> [LCM] The major piece of the patch is add setting for '*internals=NULL;'.

Yes understood, but it is already initialized to NULL before calling
rte_pmd_init_internals():
http://dpdk.org/browse/dpdk/tree/lib/librte_pmd_af_packet/rte_eth_af_packet.c#n706