[dpdk-dev] [PATCH 0/2] Fix checkpatch errors

Bruce Richardson bruce.richardson at intel.com
Mon Jan 5 13:11:16 CET 2015


On Thu, Dec 25, 2014 at 10:31:46AM -0500, Ravi Kerur wrote:
> checkpatch script is run against files in librte_acl and
> librte_mempool files. No functionality change.
> Changes are tested in Ubuntu and FreeBSD. 
> 
> Ravi Kerur (2):
>   Fix checkpatch errors in librte_acl
>   Fix checkpatch errors in librte_mempool
> 
There are quite a lot of changes in these patches for fixing style errors. While
you do call out what errors are treated as false positives, i.e. are not fixed,
I think the description also needs to call out what the main errors were that were
fixed, so that we can understand better why each chunk of code change was made.

Regards,
/Bruce


More information about the dev mailing list