[dpdk-dev] [PATCH v2] Fix rte_is_power_of_2

Qiu, Michael michael.qiu at intel.com
Mon Jan 19 11:02:12 CET 2015


On 2015/1/19 17:50, David Marchand wrote:
On Mon, Jan 19, 2015 at 10:30 AM, Qiu, Michael <michael.qiu at intel.com<mailto:michael.qiu at intel.com>> wrote:

This could be, but I hope every contributor could do basic check like
build and run of at lease one app like test-pmd, then it will reduce
most of failure we faced.

testpmd is fine, but make test should be preferred as it requires no setup and it requires no pmd to be configured.
Besides, testpmd is an application, it does not test libraries that it does not use, while make test is supposed to test all libraries.


I just use test-pmd for an example, the contributor should test his patches before send out, especially, the test need to focus on what he try to fixed.

It is a bad behavior to send out before test.

There is still the hugepages to configure when running make test so I would say "make test" should tell you so.
This will avoid wasting 10 minutes to understand why all your tests fail ...

Can anyone help document this / make it more user friendly / easier ?


--
David Marchand



More information about the dev mailing list