[dpdk-dev] [PATCH] librte_pmd_ixgbe: Add queue start failure check

Thomas Monjalon thomas.monjalon at 6wind.com
Tue Jan 27 11:00:46 CET 2015


Hi Michael,

I'm clearly not the maintainer of ixgbe, so I'd prefer someone else
reviewing this patch. However I have few comments.

2015-01-15 22:45, Michael Qiu:
> -	ixgbe_dev_rxtx_start(dev);
> +	err = ixgbe_dev_rxtx_start(dev);
> +	if (err < 0) {
> +		PMD_INIT_LOG(ERR, "Unable to start rxtx queues\n");

\n is not needed in PMD_INIT_LOG.

Is this useful to print a log here, given that there already has
some logs in ixgbe_dev_rxtx_start?

> +				PMD_INIT_LOG(ERR, "Start tx queue failed\n");
[...]
> +				PMD_INIT_LOG(ERR, "Start rx queue failed\n");

Please remove \n.

Except these minor comments, it looks good.
Thanks
-- 
Thomas


More information about the dev mailing list