[dpdk-dev] [PATCH v2] librte_pmd_ixgbe: Add queue start failure check

Thomas Monjalon thomas.monjalon at 6wind.com
Tue Jan 27 15:12:18 CET 2015


2015-01-27 20:16, Michael Qiu:
> For ixgbe, when queue start failure, for example, mbuf allocate
> failure, the device will still start success, which could be
> an issue.
> 
> Add return status check of queue start to avoid this issue.
> 
> Signed-off-by: Michael Qiu <michael.qiu at intel.com>
> ---
> v2 --> v1
> 	. remove duplicated error message in ixgbe_dev_rxtx_start()
> 	. remove '\n' in PMD_INIT_LOG()

So the braces are not needed anymore (reported by checkpatch):
> +			if (ret < 0) {
> +				return ret;
> +			}

Acked-by: Thomas Monjalon <thomas.monjalon at 6wind.com>
Applied with removed braces

Thanks
-- 
Thomas


More information about the dev mailing list