[dpdk-dev] [PATCH v16 0/6] User-space Ethtool

[Wang, Liang-min]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, July 15, 2015 1:53 AM
> To: Wang, Liang-min
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v16 0/6] User-space Ethtool
> 
> 2015-07-14 20:56, Wang, Liang-min:
> > Thomas,
> > 	The mac_addr_set is needed for ethtool net-op as described in
> > 	examples/ethtool-ethtool/lib/rte_ethtool.c
> (rte_ethtool_net_set/get_mac_addr).
> 
> That's why it should be the first patch of this series.
> You probably misread "another patch" which means different patch in same
> series.
> 
That's why this API and rest of API's added into librte_ether are all prepared in the same patch: 001.
I'm confused on your comment here. Are you asking me to break the patch 001 into two patches in the same series?
Meaning 001 and 002, would that be more confusing?

> > 	Could you use the v15 for the release?
> 
> No, there are more comments.
> 
> 
> > > -----Original Message-----
> > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > > Sent: Tuesday, July 14, 2015 4:14 PM
> > > To: Wang, Liang-min
> > > Cc: dev at dpdk.org
> > > Subject: Re: [dpdk-dev] [PATCH v16 0/6] User-space Ethtool
> > >
> > > 2015-07-14 09:11, Liang-Min Larry Wang:
> > > > v16 changes:
> > > > - Re-do patch v15 and separate changes between v15 and v14 into
> patch
> > > files 005 and 006
> > >
> > > No, you misunderstood the need.
> > > You must merge your fixes in appropriate patches.
> > > But you must separate the mac_addr_set feature in another patch as it is
> > > not related to ethtool dumps.
> > >
> > > You are winning the record of patch iterations :)
>