[dpdk-dev] [PATCH 04/11] eth: remove unnecessary return value

Stephen Hemminger stephen at networkplumber.org
Fri Jul 24 19:06:17 CEST 2015


Eliminate unnecessary variable for return value
Found with returnvar.cocci

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
 lib/librte_ether/rte_ethdev.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index a96cd4f..d72fa8e 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -1892,7 +1892,6 @@ int
 rte_eth_dev_set_vlan_offload(uint8_t port_id, int offload_mask)
 {
 	struct rte_eth_dev *dev;
-	int ret = 0;
 	int mask = 0;
 	int cur, org = 0;
 
@@ -1921,14 +1920,14 @@ rte_eth_dev_set_vlan_offload(uint8_t port_id, int offload_mask)
 		mask |= ETH_VLAN_EXTEND_MASK;
 	}
 
-	/*no change*/
+	/* no change */
 	if (mask == 0)
-		return ret;
+		return 0;
 
 	FUNC_PTR_OR_ERR_RET(*dev->dev_ops->vlan_offload_set, -ENOTSUP);
 	(*dev->dev_ops->vlan_offload_set)(dev, mask);
 
-	return ret;
+	return 0;
 }
 
 int
-- 
2.1.4



More information about the dev mailing list