[dpdk-dev] [PATCH v2 1/7] ethdev: add additional error stats

[Stephen Hemminger]

On Tue,  9 Jun 2015 16:10:40 +0100
Maryam Tahhan <maryam.tahhan at intel.com> wrote:

> Add MAC error and drop statistics to struct rte_eth_stats and the
> extended stats.
> Signed-off-by: Maryam Tahhan <maryam.tahhan at intel.com>
> ---
>  lib/librte_ether/rte_ethdev.c | 4 ++++
>  lib/librte_ether/rte_ethdev.h | 4 ++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> index 5a94654..a439b4a 100644
> --- a/lib/librte_ether/rte_ethdev.c
> +++ b/lib/librte_ether/rte_ethdev.c
> @@ -136,6 +136,10 @@ static const struct rte_eth_xstats_name_off rte_stats_strings[] = {
>  	{"rx_flow_control_xon", offsetof(struct rte_eth_stats, rx_pause_xon)},
>  	{"tx_flow_control_xoff", offsetof(struct rte_eth_stats, tx_pause_xoff)},
>  	{"rx_flow_control_xoff", offsetof(struct rte_eth_stats, rx_pause_xoff)},
> +	{"rx_mac_err", offsetof(struct rte_eth_stats, imacerr)},
> +	{"rx_phy_err", offsetof(struct rte_eth_stats, iphyerr)},
> +	{"tx_drops", offsetof(struct rte_eth_stats, odrop)},
> +	{"rx_drops", offsetof(struct rte_eth_stats, idrop)}

Are these really generic enough to put them in ethdev?