[dpdk-dev] [PATCH 2/2] vhost: realloc virtio_net and virtqueue to the same node of vring desc table
Thomas Monjalon
thomas.monjalon at 6wind.com
Wed Jun 17 19:02:22 CEST 2015
2015-06-17 18:47, Thomas Monjalon:
> 2015-06-05 11:13, Huawei Xie:
> > --- a/mk/rte.app.mk
> > +++ b/mk/rte.app.mk
> > @@ -92,6 +92,9 @@ endif # ! CONFIG_RTE_BUILD_COMBINE_LIBS
> >
> > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_PCAP) += -lpcap
> >
> > +ifeq ($(CONFIG_RTE_LIBRTE_VHOST_NUMA),y)
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST) += -lnuma
> > +
> > ifeq ($(CONFIG_RTE_LIBRTE_VHOST_USER),n)
> > _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST) += -lfuse
> > endif
>
> An endif is missing.
After adding the endif and enabling the NUMA option, these errors appear:
lib/librte_vhost/virtio-net.c:535:21: error: ‘new_vq’ may be used uninitialized in this function
lib/librte_vhost/virtio-net.c:547:63: error: ‘new_ll_dev’ may be used uninitialized in this function
Tommy,
I won't review the code, but given it doesn't build, I can guess how it has
been reviewed.
Acked-by line is valuable only if the review is carefully done.
This patch series go back to lowest merge priority.
More information about the dev
mailing list